Skip to content

Match openai logic to retry on >= 500 not == 500 #1181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 27, 2025
Merged

Match openai logic to retry on >= 500 not == 500 #1181

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
299b4d4
Match openai logic to retry on >= 500 not == 500
tconley1428 Oct 23, 2025
38a76b9
Lint
tconley1428 Oct 23, 2025
56f0c28
Merge branch 'main' into openai/retry_500s
tconley1428 Oct 24, 2025
dd1c029
Merge branch 'main' into openai/retry_500s
tconley1428 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions temporalio/contrib/openai_agents/_invoke_model_activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,15 +248,18 @@ def make_tool(tool: ToolInput) -> Tool:
) from e

# Specifically retryable status codes
if e.response.status_code in [408, 409, 429, 500]:
if (
e.response.status_code in [408, 409, 429]
or e.response.status_code >= 500
):
raise ApplicationError(
"Retryable OpenAI status code",
f"Retryable OpenAI status code: {e.response.status_code}",
non_retryable=False,
next_retry_delay=retry_after,
) from e

raise ApplicationError(
"Non retryable OpenAI status code",
f"Non retryable OpenAI status code: {e.response.status_code}",
non_retryable=True,
next_retry_delay=retry_after,
) from e