Skip to content

Nexus error serialization #1323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
VegetarianOrc wants to merge 16 commits into
base: main
Choose a base branch
from
+6,818 −3,176
Draft

Nexus error serialization #1323

Show file tree
Hide file tree
Changes from 15 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7912a77
Remove TODO comments marked as "Won't Do" in Nexus TODO triage
VegetarianOrc Jan 9, 2026
42ebe5f
After syncing with team, we're happy not inheriting from asyncio.Task…
VegetarianOrc Jan 9, 2026
e818ebb
Remove unused self._interceptors variable in Nexus worker. Remove ano…
VegetarianOrc Jan 10, 2026
b0d30ce
WIP: Update to new nexus error format
VegetarianOrc Jan 13, 2026
34a381c
Add failure converter tests for Nexus errors and ResetWorkflowError
VegetarianOrc Jan 14, 2026
8d7177f
Some bug fixes around failure (de)serialization
VegetarianOrc Jan 24, 2026
579f18a
change expected error message for operation error test
VegetarianOrc Jan 26, 2026
57058e1
Use new nexus failure branch. Use data converter to go to/from tempor…
VegetarianOrc Jan 29, 2026
9ba6a32
Update to current draft of nexus-rpc
VegetarianOrc Jan 30, 2026
3355e26
Remove HTTP-based Nexus tests and convert to workflow callers
VegetarianOrc Jan 30, 2026
c4b80e7
Remove comment about error message mismatch and restore assertion on …
VegetarianOrc Feb 2, 2026
235a116
Refactor error chain validation to use typed dataclasses
VegetarianOrc Feb 2, 2026
cd9e537
WIP: use temporal failures for nexus and allow core to convert based …
VegetarianOrc Feb 11, 2026
ef14078
Update bridge to be able to return NamespaceInfo. Fix some tests that…
VegetarianOrc Feb 11, 2026
ed93c20
Remove ResetWorkflowFailureError and restore converter to previous be…
VegetarianOrc Feb 11, 2026
18e0968
remove now unused private methods in _nexus.py
VegetarianOrc Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ license = "MIT"
license-files = ["LICENSE"]
keywords = ["temporal", "workflow"]
dependencies = [
"nexus-rpc==1.3.0",
"nexus-rpc",
"protobuf>=3.20,<7.0.0",
"python-dateutil>=2.8.2,<3 ; python_version < '3.11'",
"types-protobuf>=3.20",
Expand Down Expand Up @@ -229,3 +229,6 @@ exclude = ["temporalio/bridge/target/**/*"]
[tool.uv]
# Prevent uv commands from building the package by default
package = false

[tool.uv.sources]
nexus-rpc = { git = "https://github.com/nexus-rpc/sdk-python.git", branch = "amazzeo/add-failure" }
10 changes: 9 additions & 1 deletion temporalio/api/activity/v1/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
from .message_pb2 import ActivityOptions
from .message_pb2 import (
ActivityExecutionInfo,
ActivityExecutionListInfo,
ActivityExecutionOutcome,
ActivityOptions,
)

__all__ = [
"ActivityExecutionInfo",
"ActivityExecutionListInfo",
"ActivityExecutionOutcome",
"ActivityOptions",
]
66 changes: 63 additions & 3 deletions temporalio/api/activity/v1/message_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading