Minor edits and code cleanup #609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dandavison
commented
Aug 15, 2024
| self.http_connect_proxy_config._to_bridge_config() | ||
| if self.http_connect_proxy_config | ||
| else None | ||
| ), |
Contributor
Author
There was a problem hiding this comment.
This is not enforced by black but it is fairly standard to use parens to improve readability in this situation.
cretz
approved these changes
Aug 15, 2024
dandavison
force-pushed
the
edits
branch
2 times, most recently
from
172a13a to
12994e0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor cleanup commits I have lying around.