Skip to content

Wait for context manager to close before operating on warnings #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Wait for context manager to close before operating on warnings #667

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions tests/worker/test_workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5672,11 +5672,11 @@ async def _run_workflow_and_get_warning(self) -> bool:
== "Deliberately failing post-ContinueAsNew run"
)

unfinished_handler_warning_emitted = any(
issubclass(w.category, self._unfinished_handler_warning_cls)
for w in warnings
)
return unfinished_handler_warning_emitted
unfinished_handler_warning_emitted = any(
issubclass(w.category, self._unfinished_handler_warning_cls)
for w in warnings
)
return unfinished_handler_warning_emitted

@property
def _unfinished_handler_warning_cls(self) -> Type:
Expand Down
Loading