Skip to content

Fixing indent issue with kwargs["extra"] #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Fixing indent issue with kwargs["extra"] #789

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a8a912
Fixing indent issue with kwargs["extra"]
MasonEgger Mar 17, 2025
3c92a2e
undoing something my autoformatter tried to fix
MasonEgger Mar 17, 2025
052abb7
indent other two lines
MasonEgger Mar 17, 2025
c1756c6
Extend logging tests to cover no-info branch with bug
dandavison Mar 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions temporalio/workflow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1361,9 +1361,9 @@ def process(
if self.workflow_info_on_extra:
extra.setdefault("temporal_workflow", {}).update(update_details)

kwargs["extra"] = {**extra, **(kwargs.get("extra") or {})}
if msg_extra:
msg = f"{msg} ({msg_extra})"
kwargs["extra"] = {**extra, **(kwargs.get("extra") or {})}
if msg_extra:
msg = f"{msg} ({msg_extra})"
return (msg, kwargs)

def isEnabledFor(self, level: int) -> bool:
Expand Down