Update core env vars #964
Merged
Update core env vars #964
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
approved these changes
Jul 14, 2025
Member
|
Ah, sorry, didn't want you to deal with the metrics stuff, it's also here: #940 it has some small other changes that may be needed, these can go in in any order |
Sushisource
approved these changes
Jul 14, 2025
tconley1428
pushed a commit
that referenced
this pull request
Aug 28, 2025
* Upgrade core * rename env_vars argument to override_env_vars, update corresponding comments * gen protos * add missing grpc call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Update core to include change with fallback system environment variables for environment config.
Why?
Provide better env vars default for env config
Existing tests did not break