feat(client): add client.workflow.count high level API
#1573
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
reviewed
Nov 21, 2024
mjameswh
reviewed
Nov 21, 2024
mjameswh
reviewed
Nov 21, 2024
mjameswh
reviewed
Nov 21, 2024
mjameswh
reviewed
Nov 21, 2024
mjameswh
reviewed
Nov 21, 2024
THardy98
changed the title
countWorkflowExecutions for workflow clientclient.workflow.count high level API
mjameswh
reviewed
Nov 22, 2024
| import { ExecutionContext } from 'ava'; | ||
| import { firstValueFrom, Subject } from 'rxjs'; | ||
| import { WorkflowFailedError } from '@temporalio/client'; | ||
| import asyncRetry from 'async-retry'; |
There was a problem hiding this comment.
There are some lint warnings here. Make sure to execute npm run lint before pushing to GitHub.
There was a problem hiding this comment.
I'd run this prior to pushing, does it not make code changes, just warnings?
In any case, I've addressed the warnings.
There was a problem hiding this comment.
npm run lint should fix the code, if auto-fix is possible. Not sure why it didn't.
mjameswh
reviewed
Nov 22, 2024
mjameswh
reviewed
Nov 22, 2024
mjameswh
reviewed
Nov 22, 2024
mjameswh
reviewed
Nov 22, 2024
…iendlier option to using the corresponding GRPC method directly.
THardy98
force-pushed
the
support-countWorkflowExecutions
branch
from
345d700 to
40489d8
Compare
mjameswh
reviewed
Nov 25, 2024
mjameswh
reviewed
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Added a
countmethod to the workflow client, a higher-level, user-friendlier option to using the corresponding GRPC method directly.Closes [Feature Request] Support countWorkflowExecutions #1069
How was this tested:
Added an integration test.
Any docs updates needed?
Not sure