Skip to content

Simplify the type of MockActivityEnvironment.run #1711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Simplify the type of MockActivityEnvironment.run #1711

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eea58df
Simplify the type of `MockActivityEnvironment.run`
TastyPi May 8, 2025
1701e50
Fix build
TastyPi May 9, 2025
ba5976c
Add return type test
TastyPi May 9, 2025
24f7dbe
Merge branch 'main' into patch-1
TastyPi Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/testing/src/mocking-activity-environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export class MockActivityEnvironment extends events.EventEmitter {
/**
* Run a function in Activity Context
*/
public async run<P extends any[], R, F extends ActivityFunction<P, R>>(fn: F, ...args: P): Promise<R> {
public async run<F extends ActivityFunction>(fn: F, ...args: Parameters<F>): ReturnType<F> {
return this.activity.runNoEncoding(fn as ActivityFunction<any, any>, { args, headers: {} }) as Promise<R>;
}
}
Expand Down
Loading