Skip to content

Conversation

@THardy98
Copy link
Contributor

What was changed

Added category to ApplicationFailure, users can now specify a category to signify the severity of their application failure. Application failure categories also map to different observability behaviours, namely, a BENIGN application failure downgrades log emissions to DEBUG for activity failures.

  1. Closes [Feature Request] Apply application failure logging and metrics behaviour according to ApplicationErrorCategory #1672

  2. How was this tested:
    small integration test

@THardy98 THardy98 requested a review from a team as a code owner May 30, 2025 02:54
@mjameswh
Copy link
Contributor

That's a pretty simple feature, but still, should probably add @experimental everywhere, just for safety.

@THardy98
Copy link
Contributor Author

THardy98 commented May 30, 2025

That's a pretty simple feature, but still, should probably add @experimental everywhere, just for safety.

added experimental to the category enum docstring

@THardy98 THardy98 requested a review from mjameswh May 30, 2025 03:44
Copy link
Contributor

@mjameswh mjameswh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@THardy98 THardy98 merged commit 81c7ad2 into main May 30, 2025
26 of 27 checks passed
@THardy98 THardy98 deleted the add_application_category branch May 30, 2025 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Apply application failure logging and metrics behaviour according to ApplicationErrorCategory

3 participants