Expose Client on Activity Context #1769
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjameswh
force-pushed
the
nexus-cp-1
branch
2 times, most recently
from
8dd27dc to
d6af5a7
Compare
THardy98
approved these changes
Aug 21, 2025
THardy98
reviewed
Aug 21, 2025
| await connection.close(); | ||
| server.forceShutdown(); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Do we have a corresponding test for workflow service?
Contributor
Author
There was a problem hiding this comment.
Yes, it already existed.
Contributor
Author
Yeah, that's the way it originally was, but did something wrong during a git rebase. I'll split the PR, just for history clarity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Context.clientandgetClient()in@temporalio/activity.It is backed by the Worker's NativeConnection.
WorkerOptions.interceptors.client; those interceptors apply to theClientpassed through activities context.NativeConnection.