fix: resolve CI failure in mtls sample test #1784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…text expansion
The 'Test run a workflow (cloud)' step was failing with 'Error: EACCES: permission denied, mkdir /certs' because ${{ runner.temp }} was not expanding properly in multi-line YAML blocks.
Changes:
- Convert multi-line run block to single-line format
- Remove redundant create-certs-dir.js call (certs already created in prior step)
- Add comment explaining why single-line format is required
This ensures proper expansion of GitHub Actions context variables and prevents the '/certs' permission error.
|
I have strong doubts regarding the multiline vs single-line thing. Multiline is a YAML syntax, that should not impact expression evaluation. The real problem is the But, yeah, I agree about the redundant call to Can you just please remove the comment about single-line syntax? |
mjameswh
approved these changes
Sep 12, 2025
|
Going to bypass - test flakes are irrelevant to CI workflow change |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 'Test run a workflow (cloud)' step was failing with:
Error: EACCES: permission denied, mkdir /certsbecause${{ runner.temp }}was not expanding properly in multi-line YAML blocks.Changes:
This ensures proper expansion of GitHub Actions context variables and prevents the '/certs' permission error.