[BREAKING CHANGE] Change RawValue API - create RawValue directly from Payload #1805
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Changes the
RawValueAPI. Formerly, you could create aRawValuefrom any given value via the constructor. However, it was not possible to create aRawValuedirectly with a payload.This PR changes the API to instead:
RawValueto be created directly from a payload, via its constructor (changing the constructor signature is the breaking change)RawValueto still be created with any given value, via a static methodfromValueWhy?
Imo, this API makes more sense. If we wanted to keep the old API, but expand it to include a static for
fromPayloadit would probably look something like this:which isn't very nice, despite being a basic case.
alternatively, we could expand the type of the value in the constructor to
T | Payloadand add some type guard checks. Also not very nice, imo.How was this tested:
Updated existing tests.
Any docs updates needed?
Not sure