Skip to content

fix variable shadowing error while storing expiry time #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Shivs11 merged 2 commits into from
Jun 27, 2025
Merged

fix variable shadowing error while storing expiry time #75

Shivs11 merged 2 commits into from
Jun 27, 2025

Conversation

@Shivs11
Copy link
Member

@Shivs11 Shivs11 commented Jun 27, 2025

What was changed

  • WISOTT

Why?

  • Invalid expiry times were being stored in the client map leading to the controller always parsing the secret.

Checklist

  1. Closes

  2. How was this tested:

  1. Any docs updates needed?

@Shivs11 Shivs11 requested a review from jlegrone as a code owner June 27, 2025 04:22
@Shivs11 Shivs11 merged commit eb1fa55 into temporalio:main Jun 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlegrone jlegrone jlegrone approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Shivs11 @jlegrone