Merged
Conversation
jlegrone
reviewed
Jun 27, 2025
carlydf
commented
Jul 22, 2025
carlydf
commented
Jul 23, 2025
carlydf
commented
Jul 23, 2025
carlydf
commented
Jul 23, 2025
carlydf
commented
Jul 23, 2025
carlydf
commented
Jul 23, 2025
…own field 'spec.template.metadata.creationTimestamp' error
3a9f91c to
aec3ac6
Compare
…t fix JSON unmarshall warning
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a comprehensive integration test framework that validates the temporal worker controller's behavior end-to-end by testing against both Kubernetes and Temporal deployments. The framework includes helper utilities for creating test scenarios and setting up the test environment.
- Adds an integration test framework using Go's native testing package with real Temporal and Kubernetes environments
- Creates builder patterns for constructing test scenarios with temporal worker deployments and expected status
- Provides utilities for environment setup, worker simulation, and status verification
Reviewed Changes
Copilot reviewed 40 out of 42 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/tests/internal/integration_test.go | Main integration test logic with test scenarios for rollout strategies |
| internal/tests/internal/test_helpers.go | Helper functions for status verification and temporal deployment operations |
| internal/tests/internal/workers.go | Worker simulation code that mimics real temporal workers for testing |
| internal/tests/internal/env_helpers.go | Environment setup utilities for Kubernetes and controller initialization |
| internal/testhelpers/test_builder.go | Builder pattern utilities for constructing test cases and expected statuses |
| internal/testhelpers/make.go | Factory functions for creating test objects with proper configurations |
| internal/tests/go.mod | Go module definition for the integration tests |
| internal/tests/README.md | Comprehensive documentation for running and extending the integration tests |
Comments suppressed due to low confidence (2)
internal/tests/go.mod:3
- Go version 1.24.1 does not exist. The latest stable Go version is 1.21.x as of my knowledge cutoff. This appears to be a future version that doesn't exist yet.
go 1.24.1
internal/tests/go.mod:5
- Go toolchain version 1.24.3 does not exist. This appears to be a future version that doesn't exist yet.
toolchain go1.24.3
jlegrone
approved these changes
Jul 28, 2025
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Add integration tests
Add CI job running linters, unit tests, and integration tests
There is one TODO left in the test setup for creating a draining version. Not all possible pre-existing version statuses are tested right now, but this is ready for review while I concurrently add a few more test cases.
Why?
So that we don't break things
Checklist
Closes
How was this tested: