Skip to content

Conversation

@robholland
Copy link
Collaborator

@robholland robholland commented Jul 23, 2025

Fixes #34

@robholland robholland requested review from a team and jlegrone as code owners July 23, 2025 11:58
Copy link
Member

@Shivs11 Shivs11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a pass and left some comments

@carlydf
Copy link
Collaborator

carlydf commented Aug 8, 2025

@drewhoskins-temporal could you take a look at this? I think this doc should be designed/evaluated in the context of our other "communication" plans.

@robholland my broad comment is that I think for the Temporal Worker Versioning concepts, we should be linking out to the temporal docs liberally vs redefining things (kind of what Shivam said).

I think this is a good first step though!

Copy link
Collaborator

@carlydf carlydf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another review!
Main points in the review are:

  • Env vars are now compatible with SDK worker-options-loading library here, so we should direct people to set their workers up that way for ease.
  • I don't think we should recommend Manual rollout strategy for people's first rollout, but if you feel differently we should discuss!

@robholland robholland requested a review from carlydf September 7, 2025 11:52
@robholland robholland requested a review from jlegrone September 7, 2025 11:56
Clean up last few places that recommend Manual
@carlydf carlydf dismissed drewhoskins-temporal’s stale review September 8, 2025 21:49

Review is addressed (temporal worker versioning docs are linked, and concepts will be moved to temporal docs after merging + linked from here to temporal docs after they are moved to temporal docs), and I want to merge this PR asap

@carlydf carlydf merged commit 2c388e5 into temporalio:main Sep 8, 2025
11 checks passed
@robholland robholland deleted the rh-migration branch September 9, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document how to migrate to controller from manually managed versioned deployments

5 participants