-
Notifications
You must be signed in to change notification settings - Fork 18
Add migration doc draft. #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Shivs11
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did a pass and left some comments
|
@drewhoskins-temporal could you take a look at this? I think this doc should be designed/evaluated in the context of our other "communication" plans. @robholland my broad comment is that I think for the Temporal Worker Versioning concepts, we should be linking out to the temporal docs liberally vs redefining things (kind of what Shivam said). I think this is a good first step though! |
Refocus migration guide on unversioned -> versioned.
Co-authored-by: Carly de Frondeville <[email protected]>
carlydf
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another review!
Main points in the review are:
- Env vars are now compatible with SDK worker-options-loading library here, so we should direct people to set their workers up that way for ease.
- I don't think we should recommend Manual rollout strategy for people's first rollout, but if you feel differently we should discuss!
Clean up last few places that recommend Manual
Review is addressed (temporal worker versioning docs are linked, and concepts will be moved to temporal docs after merging + linked from here to temporal docs after they are moved to temporal docs), and I want to merge this PR asap
Fixes #34