Remove SkipGenerateWorkflowTask from signal APIs #6810
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexshtin
force-pushed
the
feature/remove-skip-wft-flag
branch
from
d1712e9 to
164cc98
Compare
alexshtin
force-pushed
the
feature/remove-skip-wft-flag
branch
from
164cc98 to
3a151d2
Compare
pdoerner
approved these changes
Nov 13, 2024
Contributor
pdoerner
left a comment
pdoerner
left a comment
There was a problem hiding this comment.
LGTM but would like someone from CGS to double check the reapply logic.
yux0
reviewed
Nov 14, 2024
| } | ||
|
|
||
| bufferedEventShouldCreateNewTask := hasBufferedEventsOrMessages && ms.HasAnyBufferedEvent(eventShouldGenerateNewTaskFilter) | ||
| if hasBufferedEventsOrMessages && !bufferedEventShouldCreateNewTask { |
Contributor
There was a problem hiding this comment.
if there is buffer events, we should still flush those events?
Contributor
Author
There was a problem hiding this comment.
Buffered events are flushed when new WFT is scheduled. This code was just to flush them if new WFT will not be created.
yux0
reviewed
Nov 14, 2024
Contributor
yux0
left a comment
yux0
left a comment
There was a problem hiding this comment.
The event reapply logic LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove
SkipGenerateWorkflowTaskflag from signal APIs request. Some sort of revert of #4091.Why?
This flag breaks important system invariant: Workflow history must end with Workflow Task event OR event that is no-op for SDK (such as
ActivityScheduledorTimerStarted). This invariant will be leverage at #6709 where server must guarantee that it won't ship actual (non command) events to the worker twice.PR to remove flag from APIs: temporalio/api#476.
How did you test it?
Existing tests.
Potential risks
Although this flag is not exposed by any SDK and not documented, there is a chance that someone use it in production scenarios. For them it will be a breaking change.
Documentation
Not documented.
Is hotfix candidate?
No.