Skip to content

worker-versioning GA: revision number to handle async workflow inconsistencies. #8553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 46 commits into
base: main
Choose a base branch
from
Open

worker-versioning GA: revision number to handle async workflow inconsistencies. #8553

Show file tree
Hide file tree
Changes from 38 commits
Commits
Show all changes
46 commits
Select commit Hold shift + click to select a range
5865ac8
current work on version routing config
Shivs11 Oct 17, 2025
c82d8f2
Merge branch 'main' into ss/version_config_counter
Shivs11 Oct 17, 2025
4d10da8
Proto changes for async deployment info propagation
ShahabT Oct 22, 2025
f4d45bf
comments
Shivs11 Oct 23, 2025
37abe4a
added revision number in MS and in task coming from history->matching
Shivs11 Oct 23, 2025
41484f1
Merge branch 'shahab/async' into ss/version_config_counter
Shivs11 Oct 23, 2025
1d93f38
current progress
Shivs11 Oct 27, 2025
5e88fc2
do not use revision number if deployment are different
Shivs11 Oct 27, 2025
b020b6a
test added for bouncing of unpinned workflows
Shivs11 Oct 28, 2025
b609e49
regenerated mocks
Shivs11 Oct 28, 2025
8cdeb6e
draft v1
Shivs11 Oct 29, 2025
9bf9c6c
draft v2
Shivs11 Oct 29, 2025
c4bf287
some todo's
Shivs11 Oct 29, 2025
c700376
address comments
Shivs11 Oct 29, 2025
e8470cb
fix buggy tests
Shivs11 Oct 29, 2025
e3fd534
remove all prints
Shivs11 Oct 30, 2025
3d8c07a
findTargetDeployment function works with old and new deploymentData
Shivs11 Oct 30, 2025
32b009c
v4: equating rev number in MS
Shivs11 Oct 30, 2025
90b6c01
Mutable state now increments revision number based on task dispatch n…
Shivs11 Oct 30, 2025
af66e45
new deployment check for blackholed queries
Shivs11 Oct 30, 2025
9bb373f
Merge branch 'main' into ss/version_config_counter
Shivs11 Oct 30, 2025
5b60385
some more tweaks after merge conflicts were resolved
Shivs11 Oct 30, 2025
1e8f565
fix breaking unit tests
Shivs11 Oct 30, 2025
3a4610e
gate revision number behind a flag in both history and matching
Shivs11 Oct 30, 2025
eb84e97
clean up PR
Shivs11 Oct 30, 2025
fcc4420
DescribeTQ also uses the latest deploymentData
Shivs11 Oct 30, 2025
c98e8d8
addressed all the changes
Shivs11 Oct 31, 2025
85a832d
more changes addressed and comments removed
Shivs11 Oct 31, 2025
3348870
Merge branch 'main' into ss/version_config_counter
Shivs11 Oct 31, 2025
a3b09a8
remove test from stats
Shivs11 Oct 31, 2025
a840b20
restore a deleted stats test
Shivs11 Oct 31, 2025
10d11c6
remove pre-release test in versioning_3_test
Shivs11 Oct 31, 2025
29d5681
pass in the nil string
Shivs11 Oct 31, 2025
2a55e2f
lint
Shivs11 Oct 31, 2025
925ebb8
fix bug in calculateTaskQueueVersioningInfo by now correctly checking…
Shivs11 Nov 4, 2025
9bb4f87
remove old deployments when RC gets updated + unversioned current/ram…
Shivs11 Nov 7, 2025
5829007
ensureRegisteredInDeploymentVersion now does a HasDeploymentVersion c…
Shivs11 Nov 7, 2025
908826d
add unit tests for both matching and worker-versioning
Shivs11 Nov 7, 2025
4b4be18
lint
Shivs11 Nov 7, 2025
7dafee3
recurring lint
Shivs11 Nov 7, 2025
dfb1c51
address comments
Shivs11 Nov 7, 2025
98468ce
clear current from RC only when required
Shivs11 Nov 7, 2025
c04944b
lint fixes and helpers
Shivs11 Nov 7, 2025
7508721
lint typo
Shivs11 Nov 7, 2025
31a39da
some final cleanup
Shivs11 Nov 7, 2025
f5a5f6e
lint keeps on failing
Shivs11 Nov 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions api/deployment/v1/message.go-helpers.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

887 changes: 469 additions & 418 deletions api/deployment/v1/message.pb.go
View file
Open in desktop

Large diffs are not rendered by default.

40 changes: 31 additions & 9 deletions api/historyservice/v1/request_response.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading