Skip to content

Add Priority tag to ApproximateBacklogCount #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add Priority tag to ApproximateBacklogCount #8557

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
586ac52
Add Priority tag to ApproximateBacklogCount
majiru Oct 28, 2025
079656c
correct metrics tags used for task queue priority and done assume
majiru Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions service/matching/db.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import (
"fmt"
"math"
"slices"
"strconv"
"sync"
"time"

Expand Down Expand Up @@ -729,10 +730,13 @@ func (db *taskQueueDB) emitBacklogGaugesLocked() {
return
}

var approximateBacklogCount, totalLag int64
var totalLag int64
var oldestTime time.Time
count := make(map[int32]int64)
for _, s := range db.subqueues {
approximateBacklogCount += s.ApproximateBacklogCount
c := count[s.Key.Priority]
c += s.ApproximateBacklogCount
count[s.Key.Priority] = c
oldestTime = minNonZeroTime(oldestTime, s.oldestTime)
// note: this metric is only an estimation for the lag.
// taskID in DB may not be continuous, especially when task list ownership changes.
Expand All @@ -745,7 +749,13 @@ func (db *taskQueueDB) emitBacklogGaugesLocked() {
}
}

metrics.ApproximateBacklogCount.With(db.metricsHandler).Record(float64(approximateBacklogCount))
for _, v := range count {
priStr := ""
if v > 0 {
priStr = strconv.FormatInt(v, 10)
}
metrics.ApproximateBacklogCount.With(db.metricsHandler).Record(float64(v), metrics.StringTag(metrics.TaskPriorityTagName, priStr))
}
if oldestTime.IsZero() {
metrics.ApproximateBacklogAgeSeconds.With(db.metricsHandler).Record(0)
} else {
Expand Down
Loading