Skip to content

Lower case headers received on ScheduleNexusOperationCommand #8561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
+9 −3
Open

Lower case headers received on ScheduleNexusOperationCommand #8561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8b94bf
Lower case headers received on ScheduleNexusOperationCommand
pdoerner Oct 28, 2025
8490c41
Lowercase headers in completion callbacks in start workflow requests
pdoerner Nov 3, 2025
f168fab
Merge branch 'main' into lower-case-nexus-headers
pdoerner Nov 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions components/nexusoperations/workflow/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,9 +109,12 @@ func (ch *commandHandler) HandleScheduleCommand(
}

headerLength := 0
lowerCaseHeader := make(map[string]string, len(attrs.NexusHeader))
for k, v := range attrs.NexusHeader {
headerLength += len(k) + len(v)
if slices.Contains(ch.config.DisallowedOperationHeaders(), strings.ToLower(k)) {
lowerK := strings.ToLower(k)
lowerCaseHeader[lowerK] = v
headerLength += len(lowerK) + len(v)
if slices.Contains(ch.config.DisallowedOperationHeaders(), lowerK) {
return workflow.FailWorkflowTaskError{
Cause: enumspb.WORKFLOW_TASK_FAILED_CAUSE_BAD_SCHEDULE_NEXUS_OPERATION_ATTRIBUTES,
Message: fmt.Sprintf("ScheduleNexusOperationCommandAttributes.NexusHeader contains a disallowed header key: %q", k),
Expand Down Expand Up @@ -158,7 +161,7 @@ func (ch *commandHandler) HandleScheduleCommand(
Operation: attrs.Operation,
Input: attrs.Input,
ScheduleToCloseTimeout: attrs.ScheduleToCloseTimeout,
NexusHeader: attrs.NexusHeader,
NexusHeader: lowerCaseHeader,
RequestId: uuid.NewString(),
WorkflowTaskCompletedEventId: workflowTaskCompletedEventID,
},
Expand Down
3 changes: 3 additions & 0 deletions service/frontend/workflow_handler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5200,8 +5200,10 @@ func (wh *WorkflowHandler) validateWorkflowCompletionCallbacks(
}

headerSize := 0
lowerCaseHeaders := make(map[string]string, len(cb.Nexus.GetHeader()))
for k, v := range cb.Nexus.GetHeader() {
headerSize += len(k) + len(v)
lowerCaseHeaders[strings.ToLower(k)] = v
}
if headerSize > wh.config.CallbackHeaderMaxSize(ns.String()) {
return status.Error(
Expand All @@ -5212,6 +5214,7 @@ func (wh *WorkflowHandler) validateWorkflowCompletionCallbacks(
),
)
}
cb.Nexus.Header = lowerCaseHeaders
case *commonpb.Callback_Internal_:
// TODO(Tianyu): For now, there is nothing to validate given that this is an internal field.
continue
Expand Down
Loading