Remove explicit status tracking from namespace registry #8948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jprieto-temporal
force-pushed
the
jprieto/mtmkupzlyoyl
branch
from
47d444f to
63fa369
Compare
jprieto-temporal
force-pushed
the
jprieto/mtmkupzlyoyl
branch
from
63fa369 to
2faa977
Compare
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove explicit lifecycle status tracking from the namespace registry.
Updated tests to guarantee Stop is called exactly once.
Why?
The namespace registry is managed by fx lifecycle hooks, which guarantee Start() and Stop() are called exactly once in order. The status tracking was defensive code that duplicated guarantees already provided by fx. Other components like the Nexus endpoint registry already rely on fx without internal status tracking.
How did you test it?
Potential risks
Tests call Start() and Stop() directly rather than through fx. These calls are no longer idempotent so behavior is undefined if a test misuses them. Existing tests are correct.