Skip to content

Improve priority semaphore #9286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
yycptt wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Improve priority semaphore #9286

yycptt wants to merge 1 commit into from
+19 −19

Conversation

@yycptt
Copy link
Member

@yycptt yycptt commented Feb 11, 2026

What changed?

  • When checking waiters, only check waiter with higher or equal priority.
  • Allow specifying priority in TryAcquire()

Why?

  • If there's all waiters have lower priority, we don't really need to create a new waiter and later unblock it.

How did you test it?

  • built
  • run locally and tested manually
  • covered by existing tests
  • added new unit test(s)
  • added new functional test(s)

@yycptt yycptt requested a review from prathyushpv February 11, 2026 00:50
prathyushpv
prathyushpv reviewed Feb 11, 2026
View reviewed changes
common/locks/priority_semaphore_impl.go
// On success, returns true. On failure, returns false and leaves the semaphore unchanged.
func (s *PrioritySemaphoreImpl) TryAcquire(n int) bool {
func (s *PrioritySemaphoreImpl) TryAcquire(priority Priority, n int) bool {
s.mu.Lock()
Copy link
Contributor

@prathyushpv prathyushpv Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is good to validate the value of priority like we do in Acquire() here.

Copy link
Member Author

@yycptt yycptt Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah makes sense. will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prathyushpv prathyushpv prathyushpv approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yycptt @prathyushpv