-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Parallelize integration tests #9292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f33a28e to
49aa22e
Compare
6d6daf0 to
1df4eb2
Compare
|
|
||
| Functional tests (in `tests/`) should all use `testcore.NewEnv(t)` which will always add `t.Parallel()`; | ||
| unless the `MustRunSequential` option is passed. | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New docs ^
| fmt.Fprintln(os.Stderr, err) | ||
| os.Exit(1) | ||
| } | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New little tool to automatically tag tests as "parallel".
| } | ||
|
|
||
| func TestMySQLSetupSchemaTestSuite(t *testing.T) { | ||
| t.Setenv("SQL_HOST", environment.GetMySQLAddress()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are now handled via SetupSuiteBase
3a09867 to
8b61fab
Compare
| git status | ||
| git diff | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ I think that's the clearest way to communicate without ambiguity
8b61fab to
09688be
Compare
What changed?
Made integration tests run in parallel.
Why?
Before: ~8min [run] 🐢
After: 3m30s [run] 🐰
How did you test it?
Potential risks
They are not known to be flaky; and anecdotally all passed on the first run.