Audit log sink management terraform #380
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david049
commented
Nov 3, 2025
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace go.temporal.io/cloud-sdk => github.com/temporalio/cloud-sdk-go v0.6.1-0.20251031194819-5117604c8a4f |
Author
There was a problem hiding this comment.
TODO: remove this after API update
alice-yin
reviewed
Nov 20, 2025
| }, nil | ||
| } | ||
|
|
||
| diags.AddError("Invalid sink configuration", "Either Kinesis or PubSub must be configured") |
Contributor
There was a problem hiding this comment.
This can be removed as it should not be hitting here.
alice-yin
reviewed
Nov 20, 2025
Comment on lines
+373
to
+377
| pubsubSinkSpec := &sinkv1.PubSubSpec{ | ||
| ServiceAccountId: pubsubSpec.ServiceAccountId.ValueString(), | ||
| TopicName: pubsubSpec.TopicName.ValueString(), | ||
| GcpProjectId: pubsubSpec.GcpProjectId.ValueString(), | ||
| } |
Contributor
There was a problem hiding this comment.
You may hit a similar ask that customer wants sa email other than saId and gcp project. I got a customer ask for gcp and I added https://github.com/temporalio/terraform-provider-temporalcloud/pull/305/files#diff-0f9ac5989d3371aad25f7ab3f9c8663c66551ffc889f50f3a3cc96c9385d6456
Member
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Adds terraform for audit log sink crud
Why?
Checklist
Closes
How was this tested:
locally tested
3. Any docs updates needed?
Note
Add Terraform resource
temporalcloud_account_audit_log_sinkwith Kinesis/PubSub support, docs, examples, tests, and provider registration.internal/provider/account_audit_log_sink_resource.goimplementing CRUD, import, timeouts, and validation (mutually exclusivekinesis/pubsub).internal/types/sink.gowithKinesisSpecModelandPubSubSpecModelattribute types/models.internal/provider/provider.go.docs/resources/account_audit_log_sink.mdand exampleexamples/resources/temporalcloud_account_audit_log_sink/resource.tf(Kinesis and PubSub).internal/provider/account_audit_log_sink_resource_test.go.go.modto replacego.temporal.io/cloud-sdkwithgithub.com/temporalio/cloud-sdk-goand syncgo.sum.Written by Cursor Bugbot for commit 5c06226. This will update automatically on new commits. Configure here.