Audit log sink management terraform #380
Conversation
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||
| ) | ||
|
|
||
| replace go.temporal.io/cloud-sdk => github.com/temporalio/cloud-sdk-go v0.6.1-0.20251031194819-5117604c8a4f |
There was a problem hiding this comment.
TODO: remove this after API update
| }, nil | ||
| } | ||
|
|
||
| diags.AddError("Invalid sink configuration", "Either Kinesis or PubSub must be configured") |
There was a problem hiding this comment.
This can be removed as it should not be hitting here.
| pubsubSinkSpec := &sinkv1.PubSubSpec{ | ||
| ServiceAccountId: pubsubSpec.ServiceAccountId.ValueString(), | ||
| TopicName: pubsubSpec.TopicName.ValueString(), | ||
| GcpProjectId: pubsubSpec.GcpProjectId.ValueString(), | ||
| } |
There was a problem hiding this comment.
You may hit a similar ask that customer wants sa email other than saId and gcp project. I got a customer ask for gcp and I added https://github.com/temporalio/terraform-provider-temporalcloud/pull/305/files#diff-0f9ac5989d3371aad25f7ab3f9c8663c66551ffc889f50f3a3cc96c9385d6456
|
cursor review |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
david049
force-pushed
the
dliu/auditlogsinktf
branch
from
dc778fa to
7d01344
Compare
| Description: "The unique identifier of the account audit log sink.", | ||
| } | ||
|
|
||
| switch idRequired { |
There was a problem hiding this comment.
Whats the idRequired for? Seems like its not really used.
| } | ||
|
|
||
| return map[string]schema.Attribute{ | ||
| "id": idAttribute, |
There was a problem hiding this comment.
Do we need this id seems like its always the same as sink_name.
There was a problem hiding this comment.
I'll remove it since it is the same
What was changed
Adds terraform for audit log sink crud
Why?
Checklist
Closes
How was this tested:
locally tested
3. Any docs updates needed?
Note
Add Terraform resource and data source to manage and read account audit log sinks (Kinesis/PubSub), with docs, examples, tests, and provider wiring.
temporalcloud_account_audit_log_sink: full CRUD with import, timeouts, and validation; supportskinesisandpubsubconfigurations.temporalcloud_account_audit_log_sink: fetches sink details (incl.state,kinesis,pubsub).KinesisSpecModelandPubSubSpecModelattr types and models ininternal/types/sink.go.github.com/temporalio/cloud-sdk-goviareplaceingo.mod/go.sum.Written by Cursor Bugbot for commit a98f32d. This will update automatically on new commits. Configure here.