Merged
Conversation
Alex-Tideman
requested review from
a team,
rossedfort and
stevekinney
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rossedfort
approved these changes
Jan 16, 2025
Contributor
rossedfort
left a comment
rossedfort
left a comment
There was a problem hiding this comment.
Code looks good, haven't done any testing yet
laurakwhit
reviewed
Jan 21, 2025
src/lib/components/workflow/client-actions/update-confirmation-modal.svelte
Show resolved
Hide resolved
hferentschik
pushed a commit
to DataDog/temporalio-ui
that referenced
this pull request
Mar 12, 2026
* Add update page and path. WIP * Wire up update call * Use update modal * Use modal submit button * Use correct lanuage prop, move success/failure to bottom of modal * Add loading state with alert if waiting on update * Update @temporalio packages, hide modal on success, fix types * Add workflowUpdateEnabled boolean * Fix update disabled translation * Add addition success check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Send a Workflow Update from the UI. Allow users to pick an update name from the list of registered updates or to send a custom update name.
When a validation error occurs in the update, the modal will remain open and show the validation error. If the update is in progress, the modal will remain open and an "In Progress" alert will show. If the update is successful, the modal will close and show a "Update successful" toast notification.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?