-
Notifications
You must be signed in to change notification settings - Fork 127
feat(workflow): split Event History into Timeline and Event History tabs #3109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
rossnelson
wants to merge
6
commits into
main
Choose a base branch
from
split-timeline-history-tabs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the combined workflow history view into two separate tabs: - Timeline: Visualization of workflow events over time - Event History: Detailed event listing with All/Compact/JSON views Implement shared state between tabs via URL query parameters so filter settings (sort order, category filter, status filter, freeze toggle) persist when navigating between tabs. URLs are now shareable with full filter state preserved.
Change workflow links throughout the UI to use routeForTimeline instead of routeForEventHistory, so users land on the new Timeline tab by default.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Update tests to reflect the new split Timeline/Event History tabs: - Add timeline-tab visibility expectations - Remove input-and-result expectations (component removed from layout) - Remove feed/compact/json hidden expectations for event link view
…y tabs Restore the Input and Results section to both workflow tabs so users can see workflow input/output on either view.
1c66d6e to
a4917aa
Compare
Move archival check inside routeForTimeline so callers don't need ternary logic. When archival=true, falls back to archival event history route since there's no archival timeline route.
Use isCategoryType filter instead of 'as EventTypeCategory[]' cast
andrewzamojc
approved these changes
Jan 23, 2026
Contributor
andrewzamojc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The persistence across tabs works great and feels intuitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
eventId,activeEvents) so users can switch views without losing contextImplementation Details
routeForTimelinefunction alongside existingrouteForEventHistoryTest plan