Workflow Pause #3114
Draft
Workflow Pause #3114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![temporal-cicd[bot]](https://avatars.githubusercontent.com/in/357945?s=60&v=4){kind=small}
| !!page.data.namespace.namespaceInfo?.capabilities?.workflowPause, | ||
| ); | ||
| const getResetDescription = ({ |
Contributor
There was a problem hiding this comment.
⚠️ Binding element 'resetAuthorized' implicitly has an 'any' type.
| ); | ||
| const getResetDescription = ({ | ||
| resetAuthorized, |
Contributor
There was a problem hiding this comment.
⚠️ Binding element 'canResetWithPendingChildWorkflows' implicitly has an 'any' type.
| const getResetDescription = ({ | ||
| resetAuthorized, | ||
| canResetWithPendingChildWorkflows, |
Contributor
There was a problem hiding this comment.
⚠️ Binding element 'resetEvents' implicitly has an 'any' type.
| id: 'workflow-pause-success-toast', | ||
| message: translate('workflows.pause-success'), | ||
| }); | ||
| } catch (err: unknown) { |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| id: 'workflow-unpause-success-toast', | ||
| message: translate('workflows.unpause-success'), | ||
| }); | ||
| } catch (err: unknown) { |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| ); | ||
| const workflowPaused = $derived(workflow?.status === 'Paused'); | ||
| const resetRunId = $derived( | ||
| workflow.workflowExtendedInfo?.resetRunId || |
Contributor
There was a problem hiding this comment.
⚠️ Type 'undefined' cannot be used as an index type.
| ) { | ||
| const formattedReason = formatReason({ | ||
| action: Action.Pause, | ||
| reason, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| ) { | ||
| const formattedReason = formatReason({ | ||
| action: Action.Unpause, | ||
| reason, |
Contributor
There was a problem hiding this comment.
⚠️ Type 'string | undefined' is not assignable to type 'string'.
| 'worker-task-reachability': `/namespaces/${parameters?.namespace}/worker-task-reachability`, | ||
| 'workflow.terminate': `/namespaces/${parameters?.namespace}/workflows/${parameters?.workflowId}/terminate`, | ||
| 'workflow.cancel': `/namespaces/${parameters.namespace}/workflows/${parameters.workflowId}/cancel`, | ||
| 'workflow.signal': `/namespaces/${parameters.namespace}/workflows/${parameters.workflowId}/signal/${parameters.signalName}`, |
Contributor
There was a problem hiding this comment.
⚠️ 'parameters' is possibly 'undefined'.⚠️ 'parameters' is possibly 'undefined'.⚠️ 'parameters' is possibly 'undefined'.
| 'workflow.terminate': `/namespaces/${parameters?.namespace}/workflows/${parameters?.workflowId}/terminate`, | ||
| 'workflow.cancel': `/namespaces/${parameters.namespace}/workflows/${parameters.workflowId}/cancel`, | ||
| 'workflow.signal': `/namespaces/${parameters.namespace}/workflows/${parameters.workflowId}/signal/${parameters.signalName}`, | ||
| 'workflow.update': `/namespaces/${parameters.namespace}/workflows/${parameters.workflowId}/update/${parameters.updateName}`, |
Contributor
There was a problem hiding this comment.
⚠️ 'parameters' is possibly 'undefined'.⚠️ 'parameters' is possibly 'undefined'.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
With
namespaceInfo>capabilities>workflowPauseenabled > go to aRunningworkflow > selectPause Workflow> enter a reason and confirmPausedSelect
Unpause Workflow> enter a reason and confirmChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
DT-3566Docs
Any docs updates needed?