Skip to content

refactor(workflow): remove minimizeEventView store#3182

Merged
rossnelson merged 3 commits intomainfrom
remove-minimize-event-view-store
Mar 19, 2026
Merged

refactor(workflow): remove minimizeEventView store#3182
rossnelson merged 3 commits intomainfrom
remove-minimize-event-view-store

Conversation

@rossnelson
Copy link
Collaborator

Summary

  • Removes the minimizeEventView persist store from event-view.ts — no longer needed after removing the expand/minimize toggle in fix(workflow): remove expand/minimize button from Event History #3181
  • Removes all references in workflow-history-layout.svelte (sticky toolbar conditional, EventTypeFilter minimized prop)
  • Removes {#key $minimizeEventView} wrapper in input-and-results-payload.svelte that forced re-renders on toggle
  • Cleans up unused twMerge import

Test plan

  • Verify Event History toolbar renders correctly without the sticky behavior conditional
  • Verify input/results payload section renders correctly without the {#key} wrapper
  • Confirm no regressions in EventTypeFilter positioning

@vercel
Copy link

vercel bot commented Feb 24, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Mar 19, 2026 2:43pm

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Feb 24, 2026

Warnings
⚠️

📊 Strict Mode: 9 errors in 3 files (0.8% of 1101 total)

src/lib/components/lines-and-dots/event-type-filter.svelte (2)
  • L41:29: Argument of type 'I18nKey | undefined' is not assignable to parameter of type '"nexus.link" | "nexus.nexus" | "nexus.target" | "nexus.endpoint" | "nexus.nexus-endpoint" | "nexus.endpoints" | "nexus.all-endpoints" | "nexus.my-endpoints" | "nexus.back-to-endpoints" | ... 1075 more ... | "workflows.children"'.
  • L57:27: Binding element 'value' implicitly has an 'any' type.
src/lib/layouts/workflow-history-layout.svelte (3)
  • L197:10: Type 'boolean | null' is not assignable to type 'boolean | undefined'.
  • L238:2: Type 'string | undefined' is not assignable to type 'string'.
  • L239:2: Type 'string | undefined' is not assignable to type 'string'.
src/lib/layouts/workflow-timeline-layout.svelte (4)
  • L116:10: Type 'boolean | null' is not assignable to type 'boolean | undefined'.
  • L144:7: Type 'WorkflowExecution | null' is not assignable to type 'WorkflowExecution'.
  • L154:14: 'workflow' is possibly 'null'.
  • L155:9: 'workflow' is possibly 'null'.

Generated by 🚫 dangerJS against 905b968

The minimizeEventView store is no longer needed after removing the
expand/minimize toggle from the Event History toolbar. This removes
the store definition, all references, and cleans up the unused
twMerge import and {#key} block that depended on it.
@rossnelson rossnelson merged commit 3dba6b1 into main Mar 19, 2026
19 checks passed
@rossnelson rossnelson deleted the remove-minimize-event-view-store branch March 19, 2026 15:17
temporal-cicd bot pushed a commit that referenced this pull request Mar 19, 2026
Auto-generated version bump from 2.47.3 to 2.48.0

Bump type: minor

Changes included:
- [`724ad982`](724ad98) feat: add long-term caching for immutable assets (#3128)
- [`510363a7`](510363a) Add unique id to filter (#3218)
- [`2bd7e168`](2bd7e16) DT-3592 - scroll to top on page change in paginated tables (#3220)
- [`1f68b8b1`](1f68b8b) Remove system.enableNexus dynamic config flag (#3221)
- [`82c3f0df`](82c3f0d) add WorkflowTaskStarted event type to valid reset points and remove unused type (#3224)
- [`d4165751`](d416575) Task failures count improvements (#3216)
- [`0a65aba3`](0a65aba) Make line breaks in JSON strings visual only (#3219)
- [`64b0abb9`](64b0abb) Allow accessToken to throw to allow it to stop execution and prevent weirdness in control flow. (#3222)
- [`3dba6b1a`](3dba6b1) refactor(workflow): remove minimizeEventView store (#3182)
- [`37d0ae41`](37d0ae4) Fix duplicate base path for filters (#3233)
- [`7df7aaef`](7df7aae) Fix infinite loop on root page if publicPath is set (#3234)
- [`98fd0b60`](98fd0b6) Format history size bytes to human-readable units (#3227)
laurakwhit added a commit that referenced this pull request Mar 19, 2026
Auto-generated version bump from 2.47.3 to 2.48.0

Bump type: minor

Changes included:
- [`724ad982`](724ad98) feat: add long-term caching for immutable assets (#3128)
- [`510363a7`](510363a) Add unique id to filter (#3218)
- [`2bd7e168`](2bd7e16) DT-3592 - scroll to top on page change in paginated tables (#3220)
- [`1f68b8b1`](1f68b8b) Remove system.enableNexus dynamic config flag (#3221)
- [`82c3f0df`](82c3f0d) add WorkflowTaskStarted event type to valid reset points and remove unused type (#3224)
- [`d4165751`](d416575) Task failures count improvements (#3216)
- [`0a65aba3`](0a65aba) Make line breaks in JSON strings visual only (#3219)
- [`64b0abb9`](64b0abb) Allow accessToken to throw to allow it to stop execution and prevent weirdness in control flow. (#3222)
- [`3dba6b1a`](3dba6b1) refactor(workflow): remove minimizeEventView store (#3182)
- [`37d0ae41`](37d0ae4) Fix duplicate base path for filters (#3233)
- [`7df7aaef`](7df7aae) Fix infinite loop on root page if publicPath is set (#3234)
- [`98fd0b60`](98fd0b6) Format history size bytes to human-readable units (#3227)

Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants