Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Alex-Tideman
approved these changes
Mar 19, 2026
temporal-cicd bot
pushed a commit
that referenced
this pull request
Mar 19, 2026
Auto-generated version bump from 2.47.3 to 2.48.0 Bump type: minor Changes included: - [`724ad982`](724ad98) feat: add long-term caching for immutable assets (#3128) - [`510363a7`](510363a) Add unique id to filter (#3218) - [`2bd7e168`](2bd7e16) DT-3592 - scroll to top on page change in paginated tables (#3220) - [`1f68b8b1`](1f68b8b) Remove system.enableNexus dynamic config flag (#3221) - [`82c3f0df`](82c3f0d) add WorkflowTaskStarted event type to valid reset points and remove unused type (#3224) - [`d4165751`](d416575) Task failures count improvements (#3216) - [`0a65aba3`](0a65aba) Make line breaks in JSON strings visual only (#3219) - [`64b0abb9`](64b0abb) Allow accessToken to throw to allow it to stop execution and prevent weirdness in control flow. (#3222) - [`3dba6b1a`](3dba6b1) refactor(workflow): remove minimizeEventView store (#3182) - [`37d0ae41`](37d0ae4) Fix duplicate base path for filters (#3233) - [`7df7aaef`](7df7aae) Fix infinite loop on root page if publicPath is set (#3234) - [`98fd0b60`](98fd0b6) Format history size bytes to human-readable units (#3227)
laurakwhit
added a commit
that referenced
this pull request
Mar 19, 2026
Auto-generated version bump from 2.47.3 to 2.48.0 Bump type: minor Changes included: - [`724ad982`](724ad98) feat: add long-term caching for immutable assets (#3128) - [`510363a7`](510363a) Add unique id to filter (#3218) - [`2bd7e168`](2bd7e16) DT-3592 - scroll to top on page change in paginated tables (#3220) - [`1f68b8b1`](1f68b8b) Remove system.enableNexus dynamic config flag (#3221) - [`82c3f0df`](82c3f0d) add WorkflowTaskStarted event type to valid reset points and remove unused type (#3224) - [`d4165751`](d416575) Task failures count improvements (#3216) - [`0a65aba3`](0a65aba) Make line breaks in JSON strings visual only (#3219) - [`64b0abb9`](64b0abb) Allow accessToken to throw to allow it to stop execution and prevent weirdness in control flow. (#3222) - [`3dba6b1a`](3dba6b1) refactor(workflow): remove minimizeEventView store (#3182) - [`37d0ae41`](37d0ae4) Fix duplicate base path for filters (#3233) - [`7df7aaef`](7df7aae) Fix infinite loop on root page if publicPath is set (#3234) - [`98fd0b60`](98fd0b6) Format history size bytes to human-readable units (#3227) Co-authored-by: laurakwhit <15069288+laurakwhit@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
When a custom base path was configured (e.g.
/custom-path), bothupdateQueryParametersandupdateMultipleQueryParameterswould produce doubled base paths like /temporal/temporal/namespacesbecauseurl.pathnamealready includes the base path, and thenresolve()prepended it again.This PR removes the
resolve()call andgoto()receives theurl.pathnamedirectly (which already contains the base path). The global$app/pathsmock now simulates a base path and all test now have updated assertions to account for the base path.Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
pnpm testpnpm test src/lib/utilities/update-query-parameters.test.tsRun the following ⬇️
Then go to http://localhost:5252/custom-path and navigate
/workflows> apply a filter/custom-pathdoes not appear twice in the URL and filters work as expectedChecklists
Draft Checklist
Merge Checklist
Issue(s) closed
Related Slack thread.
Docs
Any docs updates needed?