feat(invariants): improve precompile coverage with new handlers #2531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…StatusByIndex handlers Add new invariant test handlers to improve Rust precompile code coverage: TIP20.t.sol: - mintWithMemo: exercises tip20/mod.rs mint_with_memo path (~18 LOC) - burnWithMemo: exercises tip20/mod.rs burn_with_memo + _burn paths (~22 LOC) Both maintain existing supply conservation invariants (TEMPO-TIP6/7/8) ValidatorConfig.t.sol: - changeValidatorStatusByIndex: exercises validator_config/mod.rs change_validator_status_by_index T1+ dispatch path (~18 LOC) Verifies TEMPO-VAL5/VAL6 status toggle invariants Coverage benchmark results (10 runs, 1000 depth, seed=42): - TIP20: +12 precompile LOC hit - ValidatorConfig: +26 precompile LOC hit - Total: +35 LOC across all tests (+0.3%) - Feature diversity: +12 features (+6.6%) Amp-Thread-ID: https://ampcode.com/threads/T-019c32ac-ea85-752e-a124-01029df9c9d6 Co-authored-by: Amp <[email protected]>
grandizzy
requested review from
0xKitsune,
dankrad,
danrobinson,
howydev and
legion2002
as code owners
📊 Tempo Precompiles CoverageprecompilesCoverage: 16582/17521 lines (94.64%) File details
contractsCoverage: 164/329 lines (49.85%) File details
Total: 16746/17850 lines (93.82%) |
Add tests to catch mutations missed by cargo-mutants: - get_key: verify correct signature type for Secp256k1/P256/WebAuthn (catches match arm deletion) - get_key: verify revoked key returns zero fields (catches || vs && mutation) - get_key: verify nonexistent key returns zero fields - update_spending_limit: verify rejection on expired key (catches >= boundary) - update_spending_limit: verify enforce_limits gets enabled (catches ! deletion) - spending_limit_key: verify deterministic output and arg-order sensitivity Amp-Thread-ID: https://ampcode.com/threads/T-019c34b4-a27f-72da-994d-4c242b3d6605 Co-authored-by: Amp <[email protected]>
…in tests" This reverts commit 3eb7ee6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add new invariant test handlers to improve Rust precompile code coverage, identified through instrument-coverage benchmarking of
tempo-foundryPR #245.Changes
TIP20.t.sol — 2 new handlers:
mintWithMemo(tokenSeed, recipientSeed, amount, memoSeed)— exercisestip20::mint_with_memopathburnWithMemo(tokenSeed, amount, memoSeed)— exercisestip20::burn_with_memo+ internal_burnpathValidatorConfig.t.sol — 1 new handler:
changeValidatorStatusByIndex(indexSeed, newStatus)— exercisesvalidator_config::change_validator_status_by_indexT1+ dispatch pathCoverage Impact
Benchmarked with
-Cinstrument-coverageon the fuzz profile binary (10 runs × 1000 depth, seed=42):Not addressed (future work)
is_t2()check), not testable on current T1 hardforkcheck_and_mark_expiring_nonce, AccountKeychainauthorize_transfer, TIP20transfer_fee_pre/post_tx, FeeAMMexecute_fee_swap) — ~620 uncovered LOC not reachable from Solidity invariant testsvec.rs,array.rs,hashmap.rs) — internal implementation with Rust proptestsRelated: tempoxyz/tempo-foundry#245