Open
Conversation
CaisManai
requested changes
Sep 6, 2024
| --- | ||
| # Anonymous Suggestion Box | ||
|
|
||
| The Anon Suggestion Box demonstrates TEN's encryption capabilities in a practical scenario. Users submit encrypted suggestions, ensuring true privacy and anonymity. This showcases how TEN solves the challenge of maintaining confidentiality in transparent blockchain environments. |
Collaborator
There was a problem hiding this comment.
Can we use the word 'secrecy' instead of 'privacy' here
Collaborator
There was a problem hiding this comment.
And 'hypothetical' instead of 'practical'
| require(block.timestamp < auctionEndTime, "Auction ended"); | ||
| bids[msg.sender] += msg.value; | ||
|
|
||
| if (msg.value > highestBid) { |
Collaborator
There was a problem hiding this comment.
Since we're doing extra computation here when we're the highest bidder, would it be possible to work out when you're the highest bidder? Just keep bidding until you notice gas increases
Collaborator
There was a problem hiding this comment.
Maybe this calculation could be saved until the end and performed by whoever closes the bidding?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.