Skip to content

Updated connector logging to unwind rich logging#11

Merged
nkeuning merged 1 commit intomainfrom
fix/env-var-secret
Jan 27, 2025
Merged

Updated connector logging to unwind rich logging#11
nkeuning merged 1 commit intomainfrom
fix/env-var-secret

Conversation

@SteveMcGrath
Copy link
Contributor

Description

Rich logging presented issues within the cockpit logging UI. Removing rich logging. Also supporting reading the
credential schemas to hide environment variables that are deemed sensitive from the debug logs.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Added tests to the test suite to support new features and tested with the example connector vendored into the template.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner January 27, 2025 16:27
@nkeuning nkeuning merged commit 653fcdf into main Jan 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants