This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Fix inactive validators not displayed error#65
Open
WeiJun0827 wants to merge 1 commit intotendermint:stargatefrom
Open
Fix inactive validators not displayed error#65WeiJun0827 wants to merge 1 commit intotendermint:stargatefrom
WeiJun0827 wants to merge 1 commit intotendermint:stargatefrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
Some of the validators in a testnet are offline, they should be labeled as inactive in the validator list. But they are not displayed.
Cause
The
loadValidatorsfunction only fetches active validators(status === 'BOND_STATUS_BONDED').Revision
staking/validatorsendpoint get the validators withstatus === 'BOND_STATUS_BONDED'by default if thestatusparameter is not specified. So we should explicitly get inactive validators includingstatusinBOND_STATUS_UNBONDING,BOND_STATUS_UNBONDED, andBOND_STATUS_UNSPECIFIEDseperately, which covers all thestatusenum.