Skip to content

bug fix and remove comments #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bug fix and remove comments #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 23 additions & 35 deletions lib/main.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,6 @@ class MyApp extends StatefulWidget {
class MyAppState extends State<MyApp> with TickerProviderStateMixin {
AnimationController controller;

// bool isPlaying = false;

String get timerString {
Duration duration = controller.duration * controller.value;
return '${duration.inMinutes}:${(duration.inSeconds % 60).toString().padLeft(2, '0')}';
Expand All @@ -35,14 +33,6 @@ class MyAppState extends State<MyApp> with TickerProviderStateMixin {
vsync: this,
duration: Duration(seconds: 10),
);

// ..addStatusListener((status) {
// if (controller.status == AnimationStatus.dismissed) {
// setState(() => isPlaying = false);
// }

// print(status);
// })
}

@override
Expand All @@ -67,10 +57,11 @@ class MyAppState extends State<MyApp> with TickerProviderStateMixin {
builder: (BuildContext context, Widget child) {
return CustomPaint(
painter: TimerPainter(
animation: controller,
backgroundColor: Colors.white,
color: themeData.indicatorColor,
));
animation: controller,
backgroundColor: Colors.white,
color: themeData.indicatorColor,
)
);
},
),
),
Expand All @@ -85,13 +76,14 @@ class MyAppState extends State<MyApp> with TickerProviderStateMixin {
style: themeData.textTheme.subhead,
),
AnimatedBuilder(
animation: controller,
builder: (BuildContext context, Widget child) {
return Text(
timerString,
style: themeData.textTheme.display4,
);
}),
animation: controller,
builder: (BuildContext context, Widget child) {
return Text(
timerString,
style: themeData.textTheme.display4,
);
}
),
],
),
),
Expand All @@ -110,24 +102,20 @@ class MyAppState extends State<MyApp> with TickerProviderStateMixin {
animation: controller,
builder: (BuildContext context, Widget child) {
return Icon(controller.isAnimating
? Icons.pause
: Icons.play_arrow);

// Icon(isPlaying
// ? Icons.pause
// : Icons.play_arrow);
? Icons.pause
: Icons.play_arrow
);
},
),
onPressed: () {
// setState(() => isPlaying = !isPlaying);

if (controller.isAnimating) {
controller.stop(canceled: true);
setState(() {
controller.stop(canceled: true);
});
} else {
controller.reverse(
from: controller.value == 0.0
? 1.0
: controller.value);
from: controller.value == 0.0 ? 1.0 : controller.value
);
}
},
)
Expand Down Expand Up @@ -168,7 +156,7 @@ class TimerPainter extends CustomPainter {
@override
bool shouldRepaint(TimerPainter old) {
return animation.value != old.animation.value ||
color != old.color ||
backgroundColor != old.backgroundColor;
color != old.color ||
backgroundColor != old.backgroundColor;
}
}