refactor: use curl ghcr image, install starshp from gh release#2061
Merged
kemingy merged 3 commits intotensorchord:mainfrom Nov 10, 2025
Merged
refactor: use curl ghcr image, install starshp from gh release#2061kemingy merged 3 commits intotensorchord:mainfrom
kemingy merged 3 commits intotensorchord:mainfrom
Conversation
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Signed-off-by: Keming <kemingyang@tensorchord.ai>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR migrates starship installation from a Docker image approach to downloading directly from GitHub releases, and updates the base curl image used across various language installers. The primary goals are to simplify the build process and update dependencies.
- Removes the custom
envd-starshipDocker image and Dockerfile - Updates the curl base image from
curlimages/curl:8.11.1toghcr.io/curl/curl-container/curl-multi:8.17.0 - Implements direct download of starship binary from GitHub releases
- Adds additional language symbols to the starship configuration
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pkg/types/envd.go | Removes unused EnvdStarshipImage constant |
| pkg/lang/ir/v1/starship.go | New file implementing starship download from GitHub releases |
| pkg/lang/ir/v1/system.go | Removes old compileStarship function that used Docker image |
| pkg/lang/ir/v1/shell.go | Adds language-specific symbols for pixi, conda, nodejs, go, rust, julia, and rlang to starship config; updates fish shell download to use new curl image |
| pkg/lang/ir/v1/conda.go | Renames builderImage to curlImage and updates to new curl container version |
| pkg/lang/ir/v1/uv.go | Updates to use renamed curlImage constant |
| pkg/lang/ir/v1/rust.go | Updates to use renamed curlImage constant |
| pkg/lang/ir/v1/pixi.go | Updates to use renamed curlImage constant |
| pkg/lang/ir/v1/nodejs.go | Updates to use renamed curlImage constant |
| pkg/lang/ir/v1/julia.go | Updates to use renamed curlImage constant |
| pkg/lang/ir/v1/golang.go | Updates to use renamed curlImage constant |
| pkg/lang/ir/v1/agent.go | Updates to use renamed curlImage constant |
| base-images/envd-starship/envd-starship.Dockerfile | Removes the entire Dockerfile as it's no longer needed |
| .github/workflows/release.yml | Removes the workflow job for building and publishing the starship Docker image |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gaocegege
approved these changes
Nov 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.