Skip to content

Conversation

Giom-V
Copy link
Contributor

@Giom-V Giom-V commented Sep 8, 2025

A lot of Gemini models are native image out or native audio, so this rule was raising too many false positives.

A lot of Gemini models are native image out or native audio, so this rule was raising too many false positives.
@Giom-V Giom-V requested a review from a team as a code owner September 8, 2025 15:23
Copy link

@lucianommartins lucianommartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, approved.

Copy link
Member

@markmcd markmcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this go in the Gemini cookbook styles? the change doesn't seem Google-wide.

@Giom-V
Copy link
Contributor Author

Giom-V commented Sep 8, 2025

Can this go in the Gemini cookbook styles? the change doesn't seem Google-wide.

It can't, they are not the same thing. We're applying both styles at the moment... I could merge both into one, but that's way more work and I thought that we were the only ones using this script anyway...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants