Skip to content

[Orbit] Achieve 100% test coverage for export_saved_model #13597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LINYV0719 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Orbit] Achieve 100% test coverage for export_saved_model #13597

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions orbit/actions/export_saved_model_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,20 @@ def test_safe_normpath_gs(self):
path = export_saved_model.safe_normpath('gs://foo//bar')
self.assertEqual(path, 'gs://foo/bar')

def test_export_file_manager_negative_max_to_keep(self):
directory = self.create_tempdir()
base_name = os.path.join(directory.full_path, 'basename')

file_manager = export_saved_model.ExportFileManager(base_name, max_to_keep=-1)

tf.io.gfile.makedirs(f"{base_name}-10")
tf.io.gfile.makedirs(f"{base_name}-20")

self.assertLen(file_manager.managed_files, 2)

file_manager.clean_up()

self.assertLen(file_manager.managed_files, 2)

if __name__ == '__main__':
tf.test.main()