Skip to content

Commit 007f54b

Browse files
authored
cleanup: Delete unused rules and arguments in build toolchain. (#5981)
* The tf_ts_library "test_only" argument is unused and so is the corresponding tsconfig-test.json file. * The tf_ng_web_test_suite "runtime_deps" and "bootstrap" arguments are unused. * The tensorboard_typescript_bundle rule is unused.
1 parent 6fbe6d5 commit 007f54b

File tree

3 files changed

+3
-92
lines changed

3 files changed

+3
-92
lines changed

tensorboard/defs/defs.bzl

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -98,13 +98,11 @@ def tf_ts_library(strict_checks = True, **kwargs):
9898

9999
if strict_checks == False:
100100
tsconfig = "//:tsconfig-lax"
101-
elif "test_only" in kwargs and kwargs.get("test_only"):
102-
tsconfig = "//:tsconfig-test"
103101
kwargs.setdefault("deps", []).extend(["@npm//tslib", "//tensorboard/defs:strict_types"])
104102

105103
ts_library(tsconfig = tsconfig, supports_workers = True, **kwargs)
106104

107-
def tf_ng_web_test_suite(runtime_deps = [], bootstrap = [], deps = [], **kwargs):
105+
def tf_ng_web_test_suite(deps = [], **kwargs):
108106
"""TensorBoard wrapper for the rule for a Karma web test suite.
109107
110108
It has Angular specific configurations that we want as defaults.
@@ -115,12 +113,12 @@ def tf_ng_web_test_suite(runtime_deps = [], bootstrap = [], deps = [], **kwargs)
115113
srcs = [
116114
"//tensorboard/webapp/testing:require_js_karma_config.js",
117115
],
118-
bootstrap = bootstrap + [
116+
bootstrap = [
119117
"@npm//:node_modules/zone.js/dist/zone-testing-bundle.js",
120118
"@npm//:node_modules/reflect-metadata/Reflect.js",
121119
"@npm//:node_modules/@angular/localize/bundles/localize-init.umd.js",
122120
],
123-
runtime_deps = runtime_deps + [
121+
runtime_deps = [
124122
"//tensorboard/webapp/testing:initialize_testbed",
125123
],
126124
deps = deps + [

tensorboard/defs/hacks.bzl

Lines changed: 0 additions & 80 deletions
This file was deleted.

tsconfig-test.json

Lines changed: 0 additions & 7 deletions
This file was deleted.

0 commit comments

Comments
 (0)