Skip to content

Adds comment to ignore lints for change in TS 5.8 #6986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcra merged 1 commit into from
Apr 8, 2025
+13 −1
Merged

Adds comment to ignore lints for change in TS 5.8 #6986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tensorboard/plugins/graph/tf_graph_info/tf-node-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,10 @@ class TfNodeInfo extends LegacyElementMixin(PolymerElement) {
@computed('_node')
get _device(): string {
var node = this._node;
// TODO: go/ts58upgrade - Fix type mismatch caused by improved checking of
// returned conditional operators after upgrade
// TS2322: Type 'null' is not assignable to type 'string'.
// @ts-ignore
return node ? node.device : null;
}
@computed('_node', 'graphHierarchy')
Expand Down Expand Up @@ -675,6 +679,10 @@ class TfNodeInfo extends LegacyElementMixin(PolymerElement) {
@computed('_node')
get _subnodes(): unknown[] {
var node = this._node;
// TODO: go/ts58upgrade - Fix type mismatch caused by improved checking of
// returned conditional operators after upgrade
// TS2322: Type 'null' is not assignable to type 'unknown[]'.
// @ts-ignore
return node && node.metagraph ? node.metagraph.nodes() : null;
}
@computed('_predecessors')
Expand Down
6 changes: 5 additions & 1 deletion tensorboard/plugins/hparams/tf_hparams_parallel_coords_plot/axes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,7 +509,11 @@ export class AxesCollection {
public getAxisPosition(colIndex: number): number {
return this._draggedAxis !== null &&
this._draggedAxis.colIndex() === colIndex
? this._draggedAxisPosition
? // TODO: go/ts58upgrade - Fix type mismatch caused by improved checking
// of returned conditional operators after upgrade
// TS2322: Type 'number | null' is not assignable to type 'number'.
// @ts-ignore
this._draggedAxisPosition
: this._stationaryAxesPositions(colIndex);
}
/**
Expand Down