Skip to content

Replaces uses of deprecated library pipes with shlex #7017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arcra merged 1 commit into from
Jul 17, 2025
+5 −7
Merged

Replaces uses of deprecated library pipes with shlex #7017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tensorboard/manager_e2e_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,9 +20,9 @@
import errno
import json
import os
import pipes
import signal
import shlex
import shutil
import signal
import subprocess
import tempfile
import textwrap
Expand Down Expand Up @@ -275,7 +275,7 @@ def test_failure_unreadable_stdio(self):
rm -r %s
exit 22
"""
% pipes.quote(self.tmproot),
% shlex.quote(self.tmproot),
).lstrip(),
)
start_result = manager.start(["--logdir=./logs", "--port=0"])
Expand Down Expand Up @@ -305,7 +305,7 @@ def test_timeout(self):
printf >&2 'warn: I am tired\n'
sleep 60
"""
% pipes.quote(os.path.realpath(pid_file)),
% shlex.quote(os.path.realpath(pid_file)),
).lstrip(),
)
start_result = manager.start(
Expand Down
4 changes: 1 addition & 3 deletions tensorboard/tools/diagnose_tensorboard.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import inspect
import logging
import os
import pipes
import shlex
import socket
import subprocess
Expand Down Expand Up @@ -394,8 +393,7 @@ def stat_tensorboardinfo():
)
# This error should only appear on Unices, so it's okay to use
# Unix-specific utilities and shell syntax.
quote = getattr(shlex, "quote", None) or pipes.quote # Python <3.3
command = "chmod 777 %s" % quote(path)
command = "chmod 777 %s" % shlex.quote(path)
message = "%s\n\n\t%s" % (preamble, command)
yield Suggestion('Fix permissions on "%s"' % path, message)

Expand Down