Skip to content

Commit b7b0a52

Browse files
zoyahavtfx-copybara
authored andcommitted
Updating TODOs regarding expected sparse output shapes.
PiperOrigin-RevId: 516240945
1 parent f063786 commit b7b0a52

File tree

2 files changed

+5
-10
lines changed

2 files changed

+5
-10
lines changed

tensorflow_transform/beam/impl_test.py

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4426,7 +4426,7 @@ def test3dSparseWithTFXIO(self):
44264426
name: "x$sparse_indices_0"
44274427
type: INT
44284428
# TODO(b/184055743): Once TensorFlow is released with
4429-
# cl/342914534, uncomment.
4429+
# cl/514884437, uncomment.
44304430
# int_domain {
44314431
# min: 0
44324432
# max: 4
@@ -4436,7 +4436,7 @@ def test3dSparseWithTFXIO(self):
44364436
name: "x$sparse_indices_1"
44374437
type: INT
44384438
# TODO(b/184055743): Once TensorFlow is released with
4439-
# cl/342914534 uncomment.
4439+
# cl/514884437 uncomment.
44404440
# int_domain {
44414441
# min: 0
44424442
# max: 4
@@ -4462,11 +4462,8 @@ def test3dSparseWithTFXIO(self):
44624462
if not tft_unit.is_external_environment():
44634463
expected_metadata.generate_legacy_feature_spec = False
44644464

4465-
# TODO(b/184055743): Once TensorFlow is released with cl/342914534,
4465+
# TODO(b/184055743): Once TensorFlow is released with cl/514884437,
44664466
# remove this.
4467-
# TODO(b/184057384): Even with cl/342914534,
4468-
# transformed_metadata.deferred_schema still does not contain the shape
4469-
# information about the SparseTensor.
44704467
def int_domain_cleared(schema):
44714468
result = schema_pb2.Schema()
44724469
result.CopyFrom(schema)
@@ -4502,10 +4499,8 @@ def _assert_schemas_equal_fn(schema_dict_list):
45024499
'x$sparse_values',
45034500
tf.float32, [5, 5],
45044501
already_sorted=True),
4505-
# TODO(b/184055743): Once TensorFlow is released with cl/342914534,
4502+
# TODO(b/184055743): Once TensorFlow is released with cl/514884437,
45064503
# remove this.
4507-
# TODO(b/184057384): Even with cl/342914534, still may not contain
4508-
# the shape information about the SparseTensor.
45094504
tf.io.SparseFeature(['x$sparse_indices_0', 'x$sparse_indices_1'],
45104505
'x$sparse_values',
45114506
tf.float32, [-1, -1],

tensorflow_transform/impl_helper_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -725,7 +725,7 @@ def test_batched_placeholders_from_typespecs(self):
725725
self.assertEqual(features['dense_string'].dtype, tf.string)
726726

727727
self.assertEqual(type(features['_sparse_underscored']), tf.SparseTensor)
728-
# TODO(b/184055743): Once TensorFlow is released with cl/342914534,
728+
# TODO(b/184055743): Once TensorFlow is released with cl/514884437,
729729
# only keep the assertion of [None, None, 17].
730730
self.assertIn(features['_sparse_underscored'].get_shape().as_list(),
731731
([None, None, 17], [None, None, None]))

0 commit comments

Comments
 (0)