refactor(web): remove legacy editor#108
Conversation
Greptile SummaryThis PR removes the legacy Key findings:
Confidence Score: 3/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[EditorWithExecution] --> B{fileType?}
B -- http --> C[RequestSelectorBar]
C --> D[ResizableSplitPane]
D --> E["Left Pane\n(div.h-full.overflow-auto)"]
D --> F[Right Pane — ExecutionDetail]
E --> G[RequestWorkspaceTabs\nParams / Headers / Body]
G -.->|previously also rendered below| H["❌ HttpEditor (removed)"]
B -- script/test --> I[ResizableSplitPane]
I --> J[CodeEditor]
I --> K[ScriptPanel]
style H stroke-dasharray: 5 5,fill:#ffcccc,color:#333
Last reviewed commit: d89de71 |
| import { ScriptPanel } from '../script'; | ||
| import { CodeEditor } from './CodeEditor'; | ||
| import { HttpEditor } from './HttpEditor'; | ||
| import { RequestSelectorBar } from './RequestSelectorBar'; |
There was a problem hiding this comment.
Dead code not fully removed
The PR's stated goal is to remove the legacy HTTP editor, but HttpEditor.tsx itself was never deleted, and two other files still reference it:
packages/web/src/components/editor/index.ts(line 4) still re-exportsHttpEditor:export { HttpEditor } from './HttpEditor';
packages/web/src/components/editor/lazy.ts(line 4) still exports a lazy-loaded version:export const LazyHttpEditor = lazy(() => import('./HttpEditor'));
Since HttpEditor is no longer consumed anywhere (confirmed via search — only these two export sites reference it), these exports are now dead code that keeps the bundler from tree-shaking the entire HttpEditor module and its dependencies (codemirror, @codemirror/*). The HttpEditor.tsx source file should also be deleted as part of this refactor.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d89de71509
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Summary
This PR removes the legacy .http code editor from the HTTP route in packages/web, so the Request Workspace (Params / Headers / Body) is now the only authoring surface for HTTP requests in the left pane.
Why
Prevents dual-editing surfaces (workspace tabs + raw editor) that can drift and confuse save/execute behavior.
Aligns the UI with the phased request-workspace rollout where tab-based request editing is the primary flow.