Skip to content

refactor(web): add HTTP Editor Context and eliminate prop drilling #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andrewmelchor merged 2 commits into from
Mar 4, 2026
Merged

refactor(web): add HTTP Editor Context and eliminate prop drilling #115

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4547867
refactor(web): add HTTP Editor Context and eliminate prop drilling
andrewmelchor Mar 4, 2026
70d8b48
fix(web): address code review feedback on context implementation and …
andrewmelchor Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 3 additions & 38 deletions packages/web/src/components/editor/HttpEditorWithExecution.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
type RequestWorkspaceTabId,
RequestWorkspaceTabs
} from '../request-workspace';
import { HttpRequestEditorProvider } from './HttpRequestEditorContext';
import { RequestSelectorBar } from './RequestSelectorBar';
import { ResizableSplitPane } from './ResizableSplitPane';

Expand Down Expand Up @@ -116,7 +117,7 @@ export const HttpEditorWithExecution: Component<HttpEditorWithExecutionProps> =
});

return (
<>
<HttpRequestEditorProvider store={httpWorkspace}>
<RequestSelectorBar
requests={httpWorkspace.requests.all()}
selectedIndex={httpWorkspace.selection.index()}
Expand All @@ -135,42 +136,6 @@ export const HttpEditorWithExecution: Component<HttpEditorWithExecutionProps> =
<RequestWorkspaceTabs
activeTab={activeRequestTab()}
onTabChange={setActiveRequestTab}
selectedRequest={httpWorkspace.selection.selected()}
requestCount={httpWorkspace.requests.count()}
requestHeaders={httpWorkspace.drafts.header.draftHeaders()}
requestBodySummary={httpWorkspace.drafts.parse.bodySummary()}
requestBodyDraft={httpWorkspace.drafts.body.draftBody()}
requestBodyFormDataDraft={httpWorkspace.drafts.body.draftFormData()}
requestBodyFilePathDraft={httpWorkspace.drafts.body.draftFilePath()}
requestDetailsLoading={httpWorkspace.drafts.parse.loading()}
requestDetailsError={httpWorkspace.drafts.parse.error()}
headerDraftDirty={httpWorkspace.drafts.header.isDirty()}
headerDraftSaving={httpWorkspace.drafts.header.isSaving()}
headerDraftSaveError={httpWorkspace.drafts.header.saveError()}
onHeaderChange={httpWorkspace.drafts.header.onHeaderChange}
onAddHeader={httpWorkspace.drafts.header.onAddHeader}
onRemoveHeader={httpWorkspace.drafts.header.onRemoveHeader}
onSaveHeaders={httpWorkspace.drafts.header.onSave}
onDiscardHeaders={httpWorkspace.drafts.header.onDiscard}
bodyDraftDirty={httpWorkspace.drafts.body.isDirty()}
bodyDraftSaving={httpWorkspace.drafts.body.isSaving()}
bodyDraftSaveError={httpWorkspace.drafts.body.saveError()}
bodyDraftValidationError={httpWorkspace.drafts.body.validationError()}
bodyDraftIsJsonEditable={httpWorkspace.drafts.body.isJsonBody()}
bodyDraftTemplateWarnings={httpWorkspace.drafts.body.templateWarnings()}
onBodyChange={httpWorkspace.drafts.body.onBodyChange}
onBodyFilePathChange={httpWorkspace.drafts.body.onFilePathChange}
onBodyFormDataNameChange={httpWorkspace.drafts.body.onFormDataNameChange}
onBodyFormDataTypeChange={httpWorkspace.drafts.body.onFormDataTypeChange}
onBodyFormDataValueChange={httpWorkspace.drafts.body.onFormDataValueChange}
onBodyFormDataFilenameChange={httpWorkspace.drafts.body.onFormDataFilenameChange}
onBodyFormDataAddField={httpWorkspace.drafts.body.onAddFormDataField}
onBodyFormDataRemoveField={httpWorkspace.drafts.body.onRemoveFormDataField}
onBodyPrettify={httpWorkspace.drafts.body.onBodyPrettify}
onBodyMinify={httpWorkspace.drafts.body.onBodyMinify}
onBodyCopy={() => void httpWorkspace.drafts.body.onBodyCopy()}
onSaveBody={httpWorkspace.drafts.body.onSave}
onDiscardBody={httpWorkspace.drafts.body.onDiscard}
/>
</div>
}
Expand All @@ -193,7 +158,7 @@ export const HttpEditorWithExecution: Component<HttpEditorWithExecutionProps> =
onCollapseChange={panelState.setCollapsed}
/>
</div>
</>
</HttpRequestEditorProvider>
);
};

Expand Down
18 changes: 18 additions & 0 deletions packages/web/src/components/editor/HttpRequestEditorContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
import type { HttpRequestWorkspaceState } from '../../hooks/useHttpRequestWorkspace';
import { createSimpleContext } from '../../utils/createSimpleContext';

// Context for HTTP request editor - provides workspace state to child components
// This eliminates prop drilling from HttpEditorWithExecution to RequestWorkspaceTabs

interface HttpRequestEditorContextProps extends Record<string, unknown> {
store: HttpRequestWorkspaceState;
}

const context = createSimpleContext<HttpRequestWorkspaceState, HttpRequestEditorContextProps>({
name: 'HttpRequestEditor',
gate: false, // No async initialization needed
init: (props) => props.store
});

export const useHttpRequestEditor = context.use;
export const HttpRequestEditorProvider = context.provider;
138 changes: 54 additions & 84 deletions packages/web/src/components/request-workspace/request-workspace-tabs.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,7 @@
import { createMemo, For, Match, Show, Switch } from 'solid-js';
import type { WorkspaceRequest } from '../../sdk';
import type {
RequestBodyField,
RequestBodySummary,
RequestDetailsRow
} from '../../utils/request-details';
import { toRequestParams } from '../../utils/request-details';
import { useHttpRequestEditor } from '../editor/HttpRequestEditorContext';
import { REQUEST_WORKSPACE_TABS, type RequestWorkspaceTabId } from './model';
import {
RequestWorkspaceBodyPanel,
Expand All @@ -16,42 +12,6 @@ import {
interface RequestWorkspaceTabsProps {
activeTab: RequestWorkspaceTabId;
onTabChange: (tab: RequestWorkspaceTabId) => void;
selectedRequest?: WorkspaceRequest;
requestCount: number;
requestHeaders: RequestDetailsRow[];
requestBodySummary: RequestBodySummary;
requestBodyDraft: string;
requestBodyFormDataDraft: RequestBodyField[];
requestBodyFilePathDraft: string;
requestDetailsLoading: boolean;
requestDetailsError?: string;
headerDraftDirty: boolean;
headerDraftSaving: boolean;
headerDraftSaveError?: string;
onHeaderChange: (index: number, field: 'key' | 'value', value: string) => void;
onAddHeader: () => void;
onRemoveHeader: (index: number) => void;
onSaveHeaders: () => void;
onDiscardHeaders: () => void;
bodyDraftDirty: boolean;
bodyDraftSaving: boolean;
bodyDraftSaveError?: string;
bodyDraftValidationError?: string;
bodyDraftIsJsonEditable: boolean;
bodyDraftTemplateWarnings: string[];
onBodyChange: (value: string) => void;
onBodyFilePathChange: (value: string) => void;
onBodyFormDataNameChange: (index: number, value: string) => void;
onBodyFormDataTypeChange: (index: number, isFile: boolean) => void;
onBodyFormDataValueChange: (index: number, value: string) => void;
onBodyFormDataFilenameChange: (index: number, value: string) => void;
onBodyFormDataAddField: () => void;
onBodyFormDataRemoveField: (index: number) => void;
onBodyPrettify: () => void;
onBodyMinify: () => void;
onBodyCopy: () => void;
onSaveBody: () => void;
onDiscardBody: () => void;
}

const TAB_LABELS: Record<RequestWorkspaceTabId, string> = {
Expand All @@ -61,14 +21,19 @@ const TAB_LABELS: Record<RequestWorkspaceTabId, string> = {
};

export function RequestWorkspaceTabs(props: RequestWorkspaceTabsProps) {
const httpWorkspace = useHttpRequestEditor();

const requestParams = createMemo(() => {
const request = props.selectedRequest;
const request = httpWorkspace.selection.selected();
if (!request) {
return [];
}
return toRequestParams(request.url);
});

const selectedRequest = (): WorkspaceRequest | undefined => httpWorkspace.selection.selected();
const requestCount = (): number => httpWorkspace.requests.count();

return (
<section
class="border-b border-treq-border-light dark:border-treq-dark-border-light bg-base-100/80"
Expand All @@ -79,7 +44,7 @@ export function RequestWorkspaceTabs(props: RequestWorkspaceTabsProps) {
Request Workspace
</p>
<span class="badge badge-sm border-base-300 bg-base-200/70 font-mono text-[11px]">
{props.requestCount} req
{requestCount()} req
</span>
</div>

Expand All @@ -103,7 +68,7 @@ export function RequestWorkspaceTabs(props: RequestWorkspaceTabsProps) {
<div class="px-3 pb-3 pt-2">
<div class="rounded-box border border-base-300 bg-base-100/70 px-3 py-2 text-sm text-base-content/75">
<Show
when={props.selectedRequest}
when={selectedRequest()}
fallback={<p>Select a request to view {TAB_LABELS[props.activeTab].toLowerCase()}.</p>}
>
{(request) => (
Expand All @@ -116,59 +81,64 @@ export function RequestWorkspaceTabs(props: RequestWorkspaceTabsProps) {
</Match>
<Match when={props.activeTab === 'headers'}>
<Show
when={!props.requestDetailsLoading}
when={!httpWorkspace.drafts.parse.loading()}
fallback={<p>Loading request headers…</p>}
>
<Show
when={!props.requestDetailsError}
fallback={<p>{props.requestDetailsError}</p>}
when={!httpWorkspace.drafts.parse.error()}
fallback={<p>{httpWorkspace.drafts.parse.error()}</p>}
>
<RequestWorkspaceHeadersPanel
hasRequest={Boolean(props.selectedRequest)}
requestHeaders={props.requestHeaders}
headerDraftDirty={props.headerDraftDirty}
headerDraftSaving={props.headerDraftSaving}
headerDraftSaveError={props.headerDraftSaveError}
onHeaderChange={props.onHeaderChange}
onAddHeader={props.onAddHeader}
onRemoveHeader={props.onRemoveHeader}
onSaveHeaders={props.onSaveHeaders}
onDiscardHeaders={props.onDiscardHeaders}
hasRequest={Boolean(selectedRequest())}
requestHeaders={httpWorkspace.drafts.header.draftHeaders()}
headerDraftDirty={httpWorkspace.drafts.header.isDirty()}
headerDraftSaving={httpWorkspace.drafts.header.isSaving()}
headerDraftSaveError={httpWorkspace.drafts.header.saveError()}
onHeaderChange={httpWorkspace.drafts.header.onHeaderChange}
onAddHeader={httpWorkspace.drafts.header.onAddHeader}
onRemoveHeader={httpWorkspace.drafts.header.onRemoveHeader}
onSaveHeaders={httpWorkspace.drafts.header.onSave}
onDiscardHeaders={httpWorkspace.drafts.header.onDiscard}
/>
</Show>
</Show>
</Match>
<Match when={props.activeTab === 'body'}>
<Show when={!props.requestDetailsLoading} fallback={<p>Loading request body…</p>}>
<Show
when={!httpWorkspace.drafts.parse.loading()}
fallback={<p>Loading request body…</p>}
>
<Show
when={!props.requestDetailsError}
fallback={<p>{props.requestDetailsError}</p>}
when={!httpWorkspace.drafts.parse.error()}
fallback={<p>{httpWorkspace.drafts.parse.error()}</p>}
>
<RequestWorkspaceBodyPanel
hasRequest={Boolean(props.selectedRequest)}
requestBodySummary={props.requestBodySummary}
requestBodyDraft={props.requestBodyDraft}
requestBodyFormDataDraft={props.requestBodyFormDataDraft}
requestBodyFilePathDraft={props.requestBodyFilePathDraft}
bodyDraftDirty={props.bodyDraftDirty}
bodyDraftSaving={props.bodyDraftSaving}
bodyDraftSaveError={props.bodyDraftSaveError}
bodyDraftValidationError={props.bodyDraftValidationError}
bodyDraftIsJsonEditable={props.bodyDraftIsJsonEditable}
bodyDraftTemplateWarnings={props.bodyDraftTemplateWarnings}
onBodyChange={props.onBodyChange}
onBodyFilePathChange={props.onBodyFilePathChange}
onBodyFormDataNameChange={props.onBodyFormDataNameChange}
onBodyFormDataTypeChange={props.onBodyFormDataTypeChange}
onBodyFormDataValueChange={props.onBodyFormDataValueChange}
onBodyFormDataFilenameChange={props.onBodyFormDataFilenameChange}
onBodyFormDataAddField={props.onBodyFormDataAddField}
onBodyFormDataRemoveField={props.onBodyFormDataRemoveField}
onBodyPrettify={props.onBodyPrettify}
onBodyMinify={props.onBodyMinify}
onBodyCopy={props.onBodyCopy}
onSaveBody={props.onSaveBody}
onDiscardBody={props.onDiscardBody}
hasRequest={Boolean(selectedRequest())}
requestBodySummary={httpWorkspace.drafts.parse.bodySummary()}
requestBodyDraft={httpWorkspace.drafts.body.draftBody()}
requestBodyFormDataDraft={httpWorkspace.drafts.body.draftFormData()}
requestBodyFilePathDraft={httpWorkspace.drafts.body.draftFilePath()}
bodyDraftDirty={httpWorkspace.drafts.body.isDirty()}
bodyDraftSaving={httpWorkspace.drafts.body.isSaving()}
bodyDraftSaveError={httpWorkspace.drafts.body.saveError()}
bodyDraftValidationError={httpWorkspace.drafts.body.validationError()}
bodyDraftIsJsonEditable={httpWorkspace.drafts.body.isJsonBody()}
bodyDraftTemplateWarnings={httpWorkspace.drafts.body.templateWarnings()}
onBodyChange={httpWorkspace.drafts.body.onBodyChange}
onBodyFilePathChange={httpWorkspace.drafts.body.onFilePathChange}
onBodyFormDataNameChange={httpWorkspace.drafts.body.onFormDataNameChange}
onBodyFormDataTypeChange={httpWorkspace.drafts.body.onFormDataTypeChange}
onBodyFormDataValueChange={httpWorkspace.drafts.body.onFormDataValueChange}
onBodyFormDataFilenameChange={
httpWorkspace.drafts.body.onFormDataFilenameChange
}
onBodyFormDataAddField={httpWorkspace.drafts.body.onAddFormDataField}
onBodyFormDataRemoveField={httpWorkspace.drafts.body.onRemoveFormDataField}
onBodyPrettify={httpWorkspace.drafts.body.onBodyPrettify}
onBodyMinify={httpWorkspace.drafts.body.onBodyMinify}
onBodyCopy={() => void httpWorkspace.drafts.body.onBodyCopy()}
onSaveBody={httpWorkspace.drafts.body.onSave}
onDiscardBody={httpWorkspace.drafts.body.onDiscard}
/>
</Show>
</Show>
Expand Down
4 changes: 2 additions & 2 deletions packages/web/src/hooks/useHttpRequestWorkspace.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@ interface UseHttpRequestWorkspaceInput {
workspace: WorkspaceStore;
}

// Structured API with domain grouping - prepares for Phase 4 Context
interface HttpRequestWorkspaceState {
// Structured API with domain grouping
export interface HttpRequestWorkspaceState {
// Core request selection state
selection: {
index: Accessor<number>;
Expand Down