Skip to content

[Bug Fix] Enabling custom op name without adding stack frame locations #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[Bug Fix] Enabling custom op name without adding stack frame locations #11

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1c04e4f
enabled renaming op name without adding stack frame locations
vkovinicTT Oct 6, 2025
098d0b9
prevent scope from overwriting custom metadata
vkovinicTT Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions torch_xla/csrc/lowering_context.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,15 +78,18 @@ class HloMetadataSetter {
max_stack_depth = custom_opname_meta->max_stack_depth;
}

if (!nmeta.scope.empty()) {
else if (!nmeta.scope.empty()) {
op_name_prefix =
absl::StrCat(absl::StrReplaceAll(nmeta.scope, {{":", "_"}}), "/");
}
metadata.set_op_name(absl::StrCat(op_name_prefix, op_type));

// Sets file, line and stack_frame_id in metadata
lowering_context.stack_frame_index_builder()->AddStackFrameLocations(
nmeta.frame_info, static_cast<int>(max_stack_depth), metadata);
// NOTE: if max_stack_depth is 0, we are just renaming the op, so we don't need to add stack frame locations
if (max_stack_depth > 0) {
// Sets file, line and stack_frame_id in metadata
lowering_context.stack_frame_index_builder()->AddStackFrameLocations(
nmeta.frame_info, static_cast<int>(max_stack_depth), metadata);
}

lowering_context.builder()->SetOpMetadata(std::move(metadata));
}
Expand Down