Merged
Conversation
rpavlovicTT
requested review from
odjuricicTT,
tt-mpantic and
vkovacevicTT
as code owners
Contributor
Author
Collaborator
|
@rpavlovicTT This is a big change and should have been tested better. One of the models in the linked run hangs, and llmbox was not run. Please run llmbox models in the future for changes that have this much impact. |
Contributor
Author
the hung model was already fixed in the upcoming uplift from tt-metal (fix is in tt-mlir, just wasn't in tt-xla at the time). for llmbox tests -- my bad, I assumed they had separate settings from single chip tests |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.