This repository was archived by the owner on May 29, 2024. It is now read-only.
Conversation
0snap
changed the title
mavam
suggested changes
Jan 27, 2020
Member
mavam
left a comment
mavam
left a comment
There was a problem hiding this comment.
Looks good. I just have some minor discussion points.
| """Gracefully tries to parse and forward a message string. If the message | ||
| cannot be parsed, an error is logged and None is returned. | ||
| @param msg_str The message (JSON string) to forward | ||
| @param inq The queue to forward successfully parsed message to |
Member
There was a problem hiding this comment.
Suggested change
| @param inq The queue to forward successfully parsed message to | |
| @param inq The queue to forward the successfully parsed message to. |
| intel = map_to_internal(msg["Attribute"], msg.get("action", None), logger) | ||
| if intel: | ||
| all_intel.append(intel) | ||
| elif msg.get("Event", None) and msg.get("action", None) == "delete": |
Member
There was a problem hiding this comment.
I understand that you are preparing for MISP/MISP#4450 here. While you're at it, how about logging actions other than delete.
When we add an event, I think we don't have to do anything because we get all the contained attributes as well. Is that correct?
Then the only other action left is updating an event. I haven't check this, but I would assume that event updates don't matter for Threat Bus right now, because at this point we only care about attribute updates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MISP is not forwarding attributes when events get deleted. There is currently no means to detect deleted events without carrying state.
This PR prepares the code for once the following issue is resolved: MISP/MISP#4450