Skip to content

remove insecure credential storage support #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ryancdotorg wants to merge 1 commit into
base: master
Choose a base branch
from
Open

remove insecure credential storage support #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 0 additions & 43 deletions lib/atlassian/cli/credentials.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

module Atlassian
module Cli
class Credentials
Expand All @@ -7,7 +6,6 @@ class Credentials

def initialize
@credential_getters = []
@credential_getters << NetRc.new()
@credential_getters << Prompt.new()
end

Expand All @@ -34,47 +32,6 @@ def get_credentials(provided_user = nil, provided_pw = nil)

# implementations

class NetRc

NETRC_PATH = '.netrc'
NETRC_HOST = 'atlassian-cli.example.com'

# netrc ignores provided username
def get_credentials(provided_user = nil, provided_pw = nil)
File.open(File.join(Dir.home, NETRC_PATH)) do |f|
found_start = false
username = nil
password = nil
f.each_line do |l|
break if found_start && username && password

if l.match("^machine #{NETRC_HOST}$")
found_start = true
next
end

next unless found_start

if l.match("^login (.*)$")
username = $1
next
end

if l.match("^password (.*)$")
password = $1
next
end
end

if found_start && username && password
return [username, password]
end
return [nil, nil]
end
end

end # end class NetRc

class Prompt

def get_credentials(provided_user = nil, provided_pw = nil)
Expand Down