Update title and ogimage, add ogimage svg#136
Update title and ogimage, add ogimage svg#136mattcen wants to merge 1 commit intoterencehuynh:masterfrom
Conversation
|
I wonder whether Facebook and Twitter actually support SVG images. Hm. If you move the image, you'll have to update the meta tags for it as well. This line should do it: Line 9 in 82ee832 |
|
I wasn't necessarily suggesting changing the image displayed; just figured an SVG source was easier to update and export a JPG from. Not sure if that was clear. (It may be possible to just use the SVG as is without rasterising it; I'm not sure.) |
willhackett
left a comment
There was a problem hiding this comment.
OpenGraph does not support SVG at this time.
|
Oh, right. Wow, GitHub's diff view is terribly confusing by default for images. |
|
Let's change the opengraph image to just the emoji since it's a better representation to express the anger. And we avoid having the title anywhere near the image. Also, I think there is still some debate if we need to change the title or not: some people see the title quite appropriate, and others don't (as you've pointed out it might be considered ableist). |
|
Inkscape won't render the emoji glyph for me, so I'll leave this opengraph change to someone else. For reference, it's not just me who considers this ableist (and I was reluctant to sign as a result): https://twitter.com/miss_ella_venus/status/1071734962863271936. I do recognise the punchiness of this title, but even something like "You bunch of fools" might be better, or better still, something that avoids name calling, and labels the behaviour rather than the people: "This is careless, Labor!" But you're the boss, @terencehuynh. :) |
|
Fixes #7 |
No description provided.