Skip to content

Update title and ogimage, add ogimage svg#136

Open
mattcen wants to merge 1 commit intoterencehuynh:masterfrom
mattcen:master
Open

Update title and ogimage, add ogimage svg#136
mattcen wants to merge 1 commit intoterencehuynh:masterfrom
mattcen:master

Conversation

@mattcen
Copy link
Contributor

@mattcen mattcen commented Dec 10, 2018

No description provided.

@mattcen mattcen mentioned this pull request Dec 10, 2018
@auscompgeek
Copy link
Contributor

I wonder whether Facebook and Twitter actually support SVG images. Hm.

If you move the image, you'll have to update the meta tags for it as well. This line should do it:

import ogimage from '../components/ogimage.jpg'

@mattcen
Copy link
Contributor Author

mattcen commented Dec 10, 2018

I wasn't necessarily suggesting changing the image displayed; just figured an SVG source was easier to update and export a JPG from. Not sure if that was clear. (It may be possible to just use the SVG as is without rasterising it; I'm not sure.)

Copy link
Contributor

@willhackett willhackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OpenGraph does not support SVG at this time.

@auscompgeek
Copy link
Contributor

Oh, right. Wow, GitHub's diff view is terribly confusing by default for images.

@terencehuynh
Copy link
Owner

Let's change the opengraph image to just the emoji since it's a better representation to express the anger.

And we avoid having the title anywhere near the image.

Also, I think there is still some debate if we need to change the title or not: some people see the title quite appropriate, and others don't (as you've pointed out it might be considered ableist).

@mattcen
Copy link
Contributor Author

mattcen commented Dec 10, 2018

Inkscape won't render the emoji glyph for me, so I'll leave this opengraph change to someone else.

For reference, it's not just me who considers this ableist (and I was reluctant to sign as a result): https://twitter.com/miss_ella_venus/status/1071734962863271936. I do recognise the punchiness of this title, but even something like "You bunch of fools" might be better, or better still, something that avoids name calling, and labels the behaviour rather than the people: "This is careless, Labor!"

But you're the boss, @terencehuynh. :)

@hugomd hugomd added the enhancement New feature or request label Dec 10, 2018
@hugomd
Copy link
Collaborator

hugomd commented Dec 11, 2018

Fixes #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants