-
Notifications
You must be signed in to change notification settings - Fork 136
Newpkg: megaglest #1886
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Newpkg: megaglest #1886
Conversation
| -DCMAKE_POLICY_VERSION_MINIMUM=3.5 | ||
| -DLUA_LIBRARIES=${TERMUX_PREFIX}/lib/liblua5.2.so | ||
| -DLUA_INCLUDE_DIR=${TERMUX_PREFIX}/include/lua5.2 | ||
| -DLUA_MATH_LIBRARY=$TERMUX_STANDALONE_TOOLCHAIN/sysroot/usr/lib/$TERMUX_HOST_PLATFORM/$TERMUX_PKG_API_LEVEL/libm.so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you just write -DLUA_MATH_LIBRARY=m does that work instead and prevent the error in CI? Yes I know that some packages like neovim do this, but it just looks like a big mess, maybe it's fine with only -DLUA_MATH_LIBRARY=m. If it really does have to be like this then you can move this to termux_step_pre_configure() (like it is in neovim)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok I see when I test, it does need either that or a patch, so put it in termux_step_pre_configure() like neovim:
termux_step_pre_configure() {
TERMUX_PKG_EXTRA_CONFIGURE_ARGS+=" -DLUA_MATH_LIBRARY=$TERMUX_STANDALONE_TOOLCHAIN/sysroot/usr/lib/$TERMUX_HOST_PLATFORM/$TERMUX_PKG_API_LEVEL/libm.so"
| } | ||
|
|
||
| termux_step_post_make_install() { | ||
| echo "POST INSTALL for Menu entries" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? (is it a placeholder for WIP function?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The game does not install game data files, as they are located in a different source. This needs to be fixed so that the game and game data are installed at the same time.
You can add additional URLs in TERMUX_PKG_SRCURL, like this:
TERMUX_PKG_SRCURL=(https://github.com/MegaGlest/megaglest-source/archive/refs/tags/${TERMUX_PKG_VERSION}.tar.gz
https://github.com/MegaGlest/megaglest-data/releases/download/3.13.0/megaglest-standalone-data-${TERMUX_PKG_VERSION}.tar.xz)
TERMUX_PKG_SHA256=(e02e58c2329558cc5d67374b5e5f9b3cfaafc300b96feff71df8d4b0d39e1eaa
996040acfb338cfcbd0612b13db9c1734a7588bcc60c7e9b87e9fd619629dda3)this will make the megaglest-standalone-data be extracted somewhere in $TERMUX_PKG_SRCDIR too, in this case mixed into the other sources, and you can try to install the assets from there in termux_step_post_make_install().
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this do? (is it a placeholder for WIP function?)
Yep. I had a issues with that. I usually create a package with 1 link, not 2s and I don't know how to work on 2 archives at once.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep. I had a issues with that. I usually create a package with 1 link, not 2s and I don't know how to work on 2 archives at once.
I have given the code block which you can copy and paste in order to start with it, but if you still don't understand it, let me know and later I can try to finish the entire thing and send it
|
I don't really know why docs fail to generate, but if you want to proceed without generating docs, you could by doing this: --- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -44,7 +44,7 @@ OPTION(WANT_USE_GoogleBreakpad "Enable GoogleBreakpad support." ON)
OPTION(WANT_USE_STREFLOP "Use the library streflop." ON)
OPTION(WANT_USE_XercesC "Enable libXercesC support." OFF)
-FIND_PROGRAM(HELP2MAN "help2man")
+set(HELP2MAN "")
set(XVFB_EXEC "")
find_program(XVFB_RUN NAMES "xvfb-run")
--- a/source/glest_game/CMakeLists.txt
+++ b/source/glest_game/CMakeLists.txt
@@ -334,7 +334,7 @@ IF(BUILD_MEGAGLEST)
${TARGET_NAME}
DESTINATION ${MEGAGLEST_BIN_INSTALL_PATH})
- IF(EXISTS ${HELP2MAN} AND NOT "${MEGAGLEST_MANPAGE_INSTALL_PATH}" STREQUAL "")
+ IF(EXISTS "${HELP2MAN}" AND NOT "${MEGAGLEST_MANPAGE_INSTALL_PATH}" STREQUAL "")
MESSAGE(STATUS "**NOTE: Will Install manpage [${TARGET_NAME_MANPAGE}] to [${MEGAGLEST_MANPAGE_INSTALL_PATH}]")
# Installation of the program manpage file |
Things to improve:
The game does not install game data files, as they are located in a different source. This needs to be fixed so that the game and game data are installed at the same time.
https://github.com/MegaGlest/megaglest-data/releases/download/3.13.0/megaglest-standalone-data-3.13.0.tar.xz
Menu entries and icons are in the game data file, so they need to be copied during installation.
If you can help @robertkirkman
Game works too slow for me, however Zink works slower every month :P Does not work on virglrenderer Android (for me), but works on llvmpipe (but unplayable)