addpkg(tur/numptyphysics): 0.3.10#2213
addpkg(tur/numptyphysics): 0.3.10#2213IntinteDAO wants to merge 2 commits intotermux-user-repository:masterfrom
Conversation
|
@IntinteDAO you have made a lot of PRs here, and some of them are not merged yet, but seemed ready to me. Do you still want them to be merged, and are there any in particular you would like to merge first, or do you prefer to move them to https://github.com/termux/termux-packages ? I understand that this one you planned to move to https://github.com/termux/termux-packages , since it says that in the title, but what about the others? (I now have merge permission for both https://github.com/termux/termux-packages and https://github.com/termux-user-repository, so I can put your packages in either one once the packages are ready and after I have tested them, but I wondered which ones you wanted to actually have merged in TUR) |
| TERMUX_PKG_LICENSE="GPL-3.0" | ||
| TERMUX_PKG_MAINTAINER="@IntinteDAO" | ||
| TERMUX_PKG_VERSION=0.3.10 | ||
| TERMUX_PKG_SRCURL=https://gitlab.com/thp/numptyphysics/-/archive/0.3.10/numptyphysics-0.3.10.tar.bz2 |
There was a problem hiding this comment.
It should probably have $TERMUX_PKG_VERSION used in TERMUX_PKG_SRCURL instead of the version number hardcoded.
| std::string | ||
| Os::globalDataDir() | ||
| { | ||
| + return "@TERMUX_PREFIX@/share/games/numptyphysics/data/"; |
There was a problem hiding this comment.
This patch, and the install-path.patch above, are in my opinion both "Debianisms". I think that all they do is move the app data path around to fit a Debian policy that I don't think necessarily exists in Termux; at least in my opinion, allowing the game to use its default location (if that's $TERMUX_PREFIX/share/numptyphysics/data) is probably fine.
I understand now that you did this to xmoto, but I admit I did not think about what you were doing very critically at that time, and I assumed that maybe you had changed the paths because the game otherwise failed to launch.
Does this game fail to work if you remove the patches that create the Debianism games folder?
There was a problem hiding this comment.
I understand that there are a couple of other packages in Termux that do already install a games folder, for example xboard, but in those cases that happens because the upstream code already contains references to a games folder, meaning that upstream intended that location relative to $PREFIX for their project.
In the case of numptyphysics, upstream shows that they intend the location relative to $PREFIX to be share/numptyphysics.
The reason I just feel concerned about allowing this in Termux is because:
Termux should, in my opinion, prioritize maintaining patches that are necessary for the functioning of the software on Android and also for the functioning of the software in harmony with the other packages in Termux, and should avoid exactly duplicating patches from other distros that only serve a purpose in the other distro and have no measurable benefits for Termux. This keeps the software behavior as close as possible to the intentions of upstream developers, while also reducing the amount of maintenance work required for bumping the packages in Termux.
|
I will now focus on improving all Pull Requests. Personally, I don't care where the projects end up - it seems easier if they come from Termux Packages (because adding TUR requires installing a package that will add repositories - but X11 also requires it). I'm just working on automating the creation of packages for Termux. More difficult projects are hard to do, but simple and medium-sized games do themselves (thanks to AI). I just need to do some clean-up (preferably some script that will tell me what I'm doing wrong so I don't make mistakes “from memory”) and, of course, run tests (because a game that compiles doesn't always work correctly). I can write how to do it. But now I'm going to focus on closing as many PRs as possible. |
|
Ok that's fine, when you think one of them is ready you can tell me and I will review it further I found out eventually that some games work with both |
|
@robertkirkman The question is how to test it, remove the sdl2 package, and install sdl2-compat? |
yes |
2 participants
No description provided.